Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated namespace Views.Repositories.Codes to Views.Repositories.Code #228

Merged
merged 26 commits into from
Aug 14, 2022
Merged

Updated namespace Views.Repositories.Codes to Views.Repositories.Code #228

merged 26 commits into from
Aug 14, 2022

Conversation

Lamparter
Copy link
Collaborator

@Lamparter Lamparter commented Aug 10, 2022 •
edited

⏱️ Before you start

  • Have you checked if a similar PR has already been requested?

↗️ Related/Fixed issues

📄 Description

📸 Assets (if appropriate):

None Yet

@Lamparter Lamparter marked this pull request as draft August 10, 2022 09:56
@0x5bfa
Copy link
Owner

0x5bfa commented Aug 10, 2022

Don't rename it. many link will be broken.

@Lamparter
Copy link
Collaborator Author

Don't rename it. many link will be broken.

sure

@Lamparter Lamparter linked an issue Aug 10, 2022 that may be closed by this pull request
FluentHub Identity #224
Closed
6 tasks
@0x5bfa
Copy link
Owner

0x5bfa commented Aug 10, 2022

If you have ANY tiny fixes, such as margin/padding/grammer mistakes/. or improvements, you can update it.

@0x5bfa 0x5bfa added triage approved general updates This PR is an official general update. labels Aug 10, 2022
@Lamparter
Copy link
Collaborator Author

If you have ANY tiny fixes, such as margin/padding/grammer mistakes/. or improvements, you can update it.

sure. BTW @onein528 there's no fluenthub icon in the top left. why is this?

@0x5bfa 0x5bfa assigned Lamparter and unassigned 0x5bfa Aug 10, 2022
@0x5bfa
Copy link
Owner

0x5bfa commented Aug 10, 2022

If you have ANY tiny fixes, such as margin/padding/grammer mistakes/. or improvements, you can update it.

sure. BTW @onein528 there's no fluenthub icon in the top left. why is this?

Store only issue. idk but I will fix that GU17. GU16 is yours!

0x5bfa
0x5bfa requested changes Aug 11, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@0x5bfa
Copy link
Owner

0x5bfa commented Aug 12, 2022

ok.

@Lamparter
Copy link
Collaborator Author

@onein528 Please review.

@0x5bfa
Copy link
Owner

0x5bfa commented Aug 12, 2022

I have a situation. So, not gonna happen today, sorry.

@Lamparter Lamparter marked this pull request as ready for review August 12, 2022 22:25
0x5bfa
0x5bfa requested changes Aug 13, 2022
View reviewed changes
Copy link
Owner

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’re a lot of things that need to be changed. I will take a look what should be changed.

@Lamparter
Copy link
Collaborator Author

Lamparter commented Aug 13, 2022 •
edited

There’re a lot of things that need to be changed. I will take a look what should be changed.

@onein528?
Sorry I'm impatient.

0x5bfa
0x5bfa requested changes Aug 13, 2022
View reviewed changes
Copy link
Owner

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also need to restore Beta logo sets

README.md Outdated Show resolved Hide resolved
@0x5bfa 0x5bfa changed the title General Updates 16 Updated namespace Views.Repositories.Codes to Views.Repositories.Code Aug 14, 2022
@0x5bfa
Copy link
Owner

0x5bfa commented Aug 14, 2022

Can you @DeveloperWOW64 revert 7f145c4 and 54df4f5 ?

@0x5bfa 0x5bfa added this to the FluentHub v0.5 milestone Aug 14, 2022
@0x5bfa 0x5bfa added change requested This PR has had requested changes. and removed general updates This PR is an official general update. labels Aug 14, 2022
@Lamparter
Copy link
Collaborator Author

@onein528 Changed all the things you requested. 😁

@0x5bfa
Copy link
Owner

0x5bfa commented Aug 14, 2022

Great. Processing successfully, I will merge this!

@Lamparter
Copy link
Collaborator Author

@onein528 AZP succeeded! Now merge?

@Lamparter Lamparter requested a review from 0x5bfa August 14, 2022 09:20
0x5bfa
0x5bfa approved these changes Aug 14, 2022
View reviewed changes
Copy link
Owner

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@0x5bfa 0x5bfa merged commit 23a8971 into main Aug 14, 2022
@0x5bfa 0x5bfa deleted the gu16 branch August 14, 2022 13:17
@0x5bfa
Copy link
Owner

0x5bfa commented Aug 14, 2022

@DeveloperWOW64 Thank you!

@github-actions github-actions bot added the pr-triage/ready-to-merge This PR has been approved by an FH member. label Aug 14, 2022
@0x5bfa 0x5bfa removed change requested This PR has had requested changes. triage approved labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5bfa 0x5bfa 0x5bfa approved these changes

Assignees

@Lamparter Lamparter

Labels
pr-triage/ready-to-merge This PR has been approved by an FH member.
Projects
None yet
Milestone
FluentHub v1.0.0
Development

Successfully merging this pull request may close these issues.

FluentHub Identity
2 participants
@Lamparter @0x5bfa