Number normalizer #250
Merged
Number normalizer #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added check for null and empty, where it's possible.
Lamparter
requested changes
Sep 1, 2022
no problem! |
Lamparter
approved these changes
Sep 1, 2022
|
Already been merged tho, LGTM. |
|
I've meant to use library such as DataSizeUnits. But Our team member already merged and I will work on it. |
Lamparter
added
the
pr-triage/ready-to-merge
|
@DeveloperWOW64 We should've used something library for this such as 'DataSizeUnits'. |
Why? It's not necessary, current convertor is working well |
|
Yeah. Of course, Thank you for your contribution. But I didn't want to use helpers but converters. The reason why is easy to convert value on XAML code. |
|
It is not necessary to add observable strong properties for converted values. Converters on XAML is just able to be converted as you expected with no properties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⏱️ Before you start
📄 Description
Added number normalizer helper. It's static class, which can be used everywhere.
Also, I changed a bit repository overview.
💭 Motivation and Context
📸 Assets (if appropriate):