Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update project report templates #309

Merged
merged 16 commits into from
Sep 29, 2022
Merged

Update project report templates #309

merged 16 commits into from
Sep 29, 2022

Conversation

Lamparter
Copy link
Collaborator

⏱️ Before you start

  • Have you checked if a similar PR has already been requested?
  • Have you built and ran the app?

📄 Description

Report Templates

@Lamparter
Add stack trace to bug report
f29d81f 
I'm hopeless with YAML...
@Lamparter Lamparter self-assigned this Sep 24, 2022
0x5bfa
0x5bfa requested changes Sep 24, 2022
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@0x5bfa 0x5bfa added the type/feature-request This issue is a feature request. label Sep 24, 2022
@0x5bfa 0x5bfa added this to the Post v1 milestone Sep 24, 2022
@0x5bfa 0x5bfa added pr-triage/needs-review This PR needs review from an FH member. and removed type/feature-request This issue is a feature request. project improvements labels Sep 24, 2022
@Lamparter Lamparter removed the request for review from 0x5bfa September 25, 2022 06:32
@0x5bfa 0x5bfa marked this pull request as ready for review September 25, 2022 06:35
0x5bfa
0x5bfa previously approved these changes Sep 25, 2022
View reviewed changes
Copy link
Owner

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x5bfa 0x5bfa changed the title Report templates Update project report templates Sep 25, 2022
@github-actions github-actions bot added the pr-triage/ready-to-merge This PR has been approved by an FH member. label Sep 25, 2022
@0x5bfa 0x5bfa removed the pr-triage/needs-review This PR needs review from an FH member. label Sep 25, 2022
@0x5bfa
Copy link
Owner

0x5bfa commented Sep 25, 2022 •
edited

However, you found any tiny grammer mistakes, please fix it without a PR (you can commit directly to main).

@Lamparter
Copy link
Collaborator Author

However, you found any tiny grammer mistakes, please fix it without PR(you can commit directly to main).

I saw that; thanks.

@Lamparter Lamparter marked this pull request as draft September 26, 2022 07:07
0x5bfa
0x5bfa approved these changes Sep 27, 2022
View reviewed changes
Copy link
Owner

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed sort of. So far, LGTM.

@0x5bfa 0x5bfa added type/feature-request This issue is a feature request. and removed pr-triage/ready-to-merge This PR has been approved by an FH member. labels Sep 27, 2022
@github-actions github-actions bot added the pr-triage/ready-to-merge This PR has been approved by an FH member. label Sep 27, 2022
@0x5bfa 0x5bfa removed the pr-triage/ready-to-merge This PR has been approved by an FH member. label Sep 27, 2022
@0x5bfa
Copy link
Owner

0x5bfa commented Sep 29, 2022

@DeveloperWOW64 If you have no further commits, I'd like to merge this PR.

@Lamparter
Copy link
Collaborator Author

Lamparter commented Sep 29, 2022 •
edited

@DeveloperWOW64 If you have no further commits, I'd like to merge this PR.

Sure.

@Lamparter Lamparter marked this pull request as ready for review September 29, 2022 15:26
@Lamparter Lamparter merged commit a6a66b2 into main Sep 29, 2022
@Lamparter Lamparter deleted the templates branch September 29, 2022 15:26
@0x5bfa 0x5bfa added pr-triage/ready-to-merge This PR has been approved by an FH member. and removed type/feature-request This issue is a feature request. project improvements labels Sep 29, 2022
Lamparter added a commit that referenced this pull request Sep 29, 2022
@Lamparter
Revert "Update project report templates (#309)"
c2caa5e 
This reverts commit a6a66b2.
@Lamparter Lamparter restored the templates branch September 29, 2022 15:30
@Lamparter Lamparter mentioned this pull request Sep 29, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arihant2math arihant2math arihant2math left review comments

@0x5bfa 0x5bfa 0x5bfa approved these changes

Assignees

@Lamparter Lamparter

Labels
pr-triage/ready-to-merge This PR has been approved by an FH member.
Projects
None yet
Milestone
FluentHub v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lamparter @0x5bfa @arihant2math