Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MainPageViewModel’s Dependency Injection Type #338

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Fix MainPageViewModel’s Dependency Injection Type #338

merged 1 commit into from
Nov 9, 2022

Conversation

0x5bfa
Copy link
Owner

@0x5bfa 0x5bfa commented Nov 7, 2022

⏱️ Before you start

  • Have you checked if a similar PR has already been requested?
  • Have you built and ran the app?

💭 Motivation and context

None

📄 Description

As the title

📸 Assets (if appropriate):

None

@0x5bfa 0x5bfa requested a review from ioapiset November 7, 2022 22:39
@0x5bfa 0x5bfa self-assigned this Nov 7, 2022
@0x5bfa 0x5bfa removed the request for review from ioapiset November 7, 2022 22:39
@0x5bfa 0x5bfa added this to the Post v1 milestone Nov 7, 2022
@0x5bfa 0x5bfa changed the title Fix MainPageViewModel’s Dependency Injection Fix MainPageViewModel’s Dependency Injection Type Nov 8, 2022
@0x5bfa 0x5bfa requested a review from Lamparter November 8, 2022 11:17
@github-actions github-actions bot added the pr-triage/ready-to-merge This PR has been approved by an FH member. label Nov 9, 2022
@Lamparter Lamparter merged commit 506f7a9 into main Nov 9, 2022
@Lamparter Lamparter deleted the fix-di branch November 9, 2022 08:09
@0x5bfa 0x5bfa removed the bug-fixing label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lamparter Lamparter Lamparter approved these changes

Assignees

@0x5bfa 0x5bfa

Labels
pr-triage/ready-to-merge This PR has been approved by an FH member.
Projects
None yet
Milestone
FluentHub v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0x5bfa @Lamparter