Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI of the app intro page #353

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Improve UI of the app intro page #353

merged 3 commits into from
Dec 5, 2022

Conversation

0x5bfa
Copy link
Owner

@0x5bfa 0x5bfa commented Dec 4, 2022 •
edited

⏱️ Before you start

  • Have you checked if a similar PR has already been requested?
  • Have you built and ran the app?

💭 Motivation and context

None

📄 Description

  • Display exception details if an exception occured in authoring
  • Display 'successfully authed' info bar if so
  • Update some parts of the intro page UI

📸 Assets (if appropriate):

When managed to authorize:

image

When failed to authorize:

image

@0x5bfa 0x5bfa requested a review from ioapiset December 4, 2022 15:44
@0x5bfa 0x5bfa self-assigned this Dec 4, 2022
@0x5bfa 0x5bfa added the pr-triage/needs-review This PR needs review from an FH member. label Dec 4, 2022
@0x5bfa 0x5bfa added this to the Post v1 milestone Dec 4, 2022
@0x5bfa 0x5bfa merged commit 78b5b9f into main Dec 5, 2022
@0x5bfa 0x5bfa deleted the improve-intro branch December 5, 2022 02:35
@0x5bfa 0x5bfa added pr-triage/ready-to-merge This PR has been approved by an FH member. and removed pr-triage/needs-review This PR needs review from an FH member. labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioapiset ioapiset Awaiting requested review from ioapiset

Assignees

@0x5bfa 0x5bfa

Labels
pr-triage/ready-to-merge This PR has been approved by an FH member.
Projects
None yet
Milestone
FluentHub v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@0x5bfa