DisplayName should be consistent between RuleFor.ForEach and RuleForEach

[lust4life]

System Details

• FluentValidation version: 8.4

Issue Description

https://github.com/JeremySkinner/FluentValidation/blob/2eb493886b3f2f630f6c82ae7fc1baf6f34ec496/src/FluentValidation/Validators/PropertyValidatorContext.cs#L31

        public class Foo
        {
            public List<int> Numbers { get; set; }
        }

        [Fact]
        public void Should_show_property_name()
        {
            var validator = new InlineValidator<Foo>();
            validator.RuleFor(x => x.Numbers).ForEach(x => x.GreaterThan(10));

            validator.ShouldHaveValidationErrorFor(x => x.Numbers, new List<int>() {2})
                     .WithErrorMessage("'Numbers[0]' must be greater than '10'.");
            
            validator = new InlineValidator<Foo>();
            validator.RuleForEach(x => x.Numbers).GreaterThan(10);

            validator.ShouldHaveValidationErrorFor(x => x.Numbers, new List<int>() {2})
                     .WithErrorMessage("'Numbers[0]' must be greater than '10'.");

        }

maybe because https://github.com/JeremySkinner/FluentValidation/blob/2eb493886b3f2f630f6c82ae7fc1baf6f34ec496/src/FluentValidation/DefaultValidatorExtensions.cs#L1091 using a InlineValidator<IEnumerable<TElement>>() with x=>x lambda, so the MemberInfo will be resolved as null.

[JeremySkinner]

Please can you provide the following information which was asked for in the issue template:

• Version of FluentValidation that you're using
• All code necesasry to reproduce the issue (if you can write a unit test that'd be even more helpful)

Thanks.

[lust4life]

@JeremySkinner code updated.

[JeremySkinner]

Thanks for the updated example. This is technically the correct behaviour as the display name is the always the name of the property being validated. In this case, you're not validating a property, so it will correctly be an empty string and you're expected to provide a name using WithName.

However I agree that this isn't particularly intuitive or useful so will look at the implications of changing this for a future version.

[lust4life]

😉

[ahi-el]

@JeremySkinner Hi Jeremy, this does seem to be the correct behavior. Do you have any idea how to prevent this kind of issue?
Is there some way to hint that they should use 'WithName'?

[JeremySkinner]

Implemented in 40dbb78 and will be part of 10.2.