Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color profile is changing without applying any filter - SwiftUICropView #167

Closed
iamhtz opened this issue Apr 7, 2022 · 6 comments
Closed

Comments

@iamhtz
Copy link

iamhtz commented Apr 7, 2022

Overview

I am using your library to crop different images and send them to a network call.
I noticed that when I give an image to your library it changes the color profile.
Are you processing any work on image? Are you planning to provide any API to avoid this automatic process?
Finally, thank you for your great work.

Details

I am using SwiftUICropView

Please check difference between this two following images

original
Original image

in-clipdrop-edition
Processed by Brightroom image

Reproduce version

Brightroom 2.3.3

@muukii
Copy link
Collaborator

muukii commented Apr 8, 2022

I see, it's changing DisplayP3 to sRGB.
How to render this image? Might solve this issue with specifying options.

@muukii
Copy link
Collaborator

muukii commented Apr 11, 2022

OK, I fixed it.
From now, Renderer creates an image with original image's colorprofile
#168

@muukii
Copy link
Collaborator

muukii commented Apr 11, 2022

If you need to get converted image, specify options in render()

@muukii
Copy link
Collaborator

muukii commented Apr 11, 2022

@muukii muukii closed this as completed Apr 11, 2022
@iamhtz
Copy link
Author

iamhtz commented Apr 11, 2022

Thank you for your great work @muukii ! 🚀

@muukii
Copy link
Collaborator

muukii commented Apr 23, 2022

Sorry, I put a mistake.
this fixes #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants