Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAL101 #11

Closed
raecv opened this issue Dec 3, 2021 · 1 comment
Closed

VAL101 #11

raecv opened this issue Dec 3, 2021 · 1 comment

Comments

@raecv
Copy link

raecv commented Dec 3, 2021

  1. How do you check that your code works?

You can set up tests to make sure you get the results you expect when you run your code.

  1. Pick an R package you use frequently. Find an issue associated with a fixed bug.
    Summarize the bug. Was there a conversation about what caused the bug or how to fix it? How many lines of code changed in the fix?

ggrepel bug: slowkow/ggrepel#200

Someone noticed that if you try to control the alignment of text within boxes with hjust it affects both the text and the boxes they are in. The user suggested fixing it by adding arguments to hjust to control text and boxes separately: label.hjust and box.hjust respectively.

In the conversation the user provided reprex and related issues. Most people argreed with the suggestions they gave to split it in two, since this is consistent with ggplot2 logic. They eventually opened a feature request. I think eventually they fixed it by using positiion_nudge_to() from the ggpp package, so not many lines of code at all.

@cypayne
Copy link
Collaborator

cypayne commented Dec 7, 2021

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants