Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Es6 implement #1

Merged
merged 4 commits into from Aug 8, 2022
Merged

Es6 implement #1

merged 4 commits into from Aug 8, 2022

Conversation

Flunavgt
Copy link
Owner

@Flunavgt Flunavgt commented Aug 8, 2022

On this project the following actions were implemented:

Create a new directory and initialize it with git.
Use npm init -y command to create package.json file.
Create the entry point for your JavaScript code called index.js
Create index.css file for your styles.
Create the main index.html file. Link your index.js and index.css files there.
Create a directory called modules.
Re-create your Awesome books app following the rules:

Use ES6 syntax.
Divide your code into modules. Save each module in a separate file in the modules dir. Import modules in the index.js file. For this exercise - the more modules the better!
Keep all funcionalities of the app without errors.
Refactor your methods and functions to arrow functions.
Use let and const in a correct way.
Display the current date below the navigation bar.

For this requirement you should use Luxon library
Download the script and save it to your project.
Import it as a module.

Copy link

@ShahierNashaat ShahierNashaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Flunavgt,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

To Highlight 💯

  • Correct use of GitFlow ✔️
  • Descriptive commit messages ✔️
  • Professional looking pull request ✔️
  • Your readme looks professional ✔️
  • Good overall design ✔️
  • Your code is clean and well documented ✔️

Required Changes ♻️

  • Kindly be noticed that the current date is displayed below the navigation bar and the package is added as a .js file to the project.

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Copy link

@sja-thedude sja-thedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project Approved 👍

Hi @Flunavgt, This is @sja-thedude your code reviewer.

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

giphy

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me [@sja-thedude] in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Flunavgt Flunavgt merged commit ae3ae58 into main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants