Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a subpackage for Makie support #241

Closed
lorenzoh opened this issue Jun 20, 2022 · 1 comment · Fixed by #240
Closed

Make a subpackage for Makie support #241

lorenzoh opened this issue Jun 20, 2022 · 1 comment · Fixed by #240

Comments

@lorenzoh
Copy link
Member

lorenzoh commented Jun 20, 2022 •
edited

FastMakie can be a subpackage living in the FastAI repo that implements the Makie ShowBackend. Subpackages can then depend on MakieCore.jl to define recipes and we don't need Requires anymore.

Since this will be breaking as well, it should be released together with the other breaking changes #196 and #240. #224 also needs to be fixed for this.
@lorenzoh
Copy link
Member Author

Closed by #240

@lorenzoh lorenzoh mentioned this issue Jun 21, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move domain-specific functionality to subpackages FluxML/FastAI.jl
1 participant
@lorenzoh