Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate track_stats=true for GroupNorm and InstanceNorm #2006

Closed
ToucheSir opened this issue Jun 24, 2022 · 3 comments
Closed

Deprecate track_stats=true for GroupNorm and InstanceNorm #2006

ToucheSir opened this issue Jun 24, 2022 · 3 comments

Comments

@ToucheSir
Copy link
Member

ToucheSir commented Jun 24, 2022

We discussed this on Slack, and it appears other libraries do not track running stats for either. Nor do any papers appear to make use of a running average. Thus the complexity feels very much not worth it, and doing it by default creates unnecessary inconsistencies with the rest of the ecosystem.

The rough deprecation plan for this is as follows:

  1. Emit a warning when users pass track_stats=true, with a pointer to use track_stats=false since the former will go away in the next breaking Flux release. This is the "good first issue" part.
  2. For that breaking release, remove the tracking entirely and leave track_stats as a vestigial kwarg. Alternatively, we could remove it completely.
@akahard2dj
Copy link
Contributor

akahard2dj commented Aug 6, 2022

Hello! Julia Libraty contirbution is first time in my life!
Should I scratch this one?

@ToucheSir
Copy link
Member Author

If this is your first PR to any Julia library, it may be a little tricky. Feel free to take a shot though :)

@ToucheSir
Copy link
Member Author

This was fixed in #2042, but it was overzealous in the specification and erroneously included InstanceNorm. #2149 fixes that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants