Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register? #43

Open
DhairyaLGandhi opened this issue Apr 30, 2020 · 5 comments
Open

Register? #43

DhairyaLGandhi opened this issue Apr 30, 2020 · 5 comments

Comments

@DhairyaLGandhi
Copy link
Member

No description provided.

@darsnack
Copy link
Member

darsnack commented May 12, 2020

Would it make sense to use https://github.com/JuliaPOMDP/RLInterface.jl before registering this? That would make the environments interface with the rest of JuliaPOMDP which has a lot of policies and methods already implemented. I could see if there is interest in the community coordination efforts to work on this.

I can work on this package starting June-ish.

@avik-pal
Copy link
Member

Maybe we should be using https://github.com/JuliaReinforcementLearning/CommonRLInterface.jl which would allow using the JuliaReinforcementLearning policies in addition to POMDP ones.

@darsnack
Copy link
Member

Yup I was thinking the same thing. Would be happy to give it a shot. Maybe this weekend?

@avik-pal
Copy link
Member

From the discussion there it seems that most of the functionality of this package is already provided in RLEnv (and they work pretty well from my experience), only it doesn't have headless rendering for image-based observation spaces. Makes me wonder why do we need this package specifically, and not just contribute the rendering feature there.

@darsnack
Copy link
Member

darsnack commented Jul 21, 2020

Again was thinking along the same lines when I was commenting on that issue. RLEnv implements an interface that supersedes CommonRLInterface. I was thinking of doing the later here as a "test." Then porting the headless stuff over the RLEnv for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants