New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indefinite (as opposed to nextTransition) holds? #1
Comments
Should this be configurable as the default for all holds, or some Action that does it one time? |
Definitely don't want to be greedy/demanding, but configurable holds would be incredible. Believe the API supports several types: dateTime, nextTransition, indefinite, holdHours. nextTransition and indefinite are more than adequate for my purposes. |
Well, if I put in a choice, I'll probably put them all in. When you modified the original, did you make it configurable or did you just make all holds indefinite? |
Just made them all indefinite and used the resume feature to get back on schedule. |
OK, thanks. I'll have to think about that. |
Try this version: https://github.com/FlyingDiver/Indigo-Ecobee-2/releases/tag/2.1.0 |
Just tested and working as expected. Thank you! My preferred hold type is nextTransition unless I'm setting an away hold. So... I do the following with an away scene: set hold type: indefinite, activate comfort setting: away, set hold type: nextTransition. Works perfectly, but is there a more direct way to do this? |
I can probably add hold type as an option on the activate comfort setting action. |
That option might be a bit more obvious/user-friendly, but definitely not necessary. |
Can you test 2.1.3. for this request? Please set up an action to set the climate type before you install this version, and verify it still works the way you expect. Then set up a new action with your preferred hold type and test that. https://github.com/FlyingDiver/Indigo-Ecobee-2/releases/tag/2.1.3 |
Working exactly as expected. Thanks for implementing this. One thing to note: looks like both the old and the new methods exist in 2.1.3. Imagine you will have that resolved once this enhancement is released. Thanks again, Joe. |
I was planning on leaving both in. Is there a reason to take the other one out? |
That works. How persistent was the old option? Does it apply to all future holds or just for a certain period of time? They do behave slightly differently — might be helpful to briefly document the differences. |
The other sets the default for that thermostat. Until you change it again. Or override it for a specific action. It really only applies to temp changes since the climate request now has it's own hold selection. |
Makes sense. Maybe updating the name of that function to “Set Default Hold Type” or similar would help differentiate the two options? |
Done in 2.1.4 |
Quickly re: climate holds: I had modified the original Ecobee plugin to set an indefinite away hold as opposed to an away until nextTransition hold. This is extremely useful if you're away for several hours or days. Could be a nice addition for a lot of folks. Thanks for the great plugin and your consideration!
The text was updated successfully, but these errors were encountered: