-
-
Notifications
You must be signed in to change notification settings - Fork 136
/
abstract-provider.service.spec.ts
524 lines (427 loc) 路 14.8 KB
/
abstract-provider.service.spec.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
// std
import { deepStrictEqual, notStrictEqual, ok, strictEqual } from 'assert';
import { URLSearchParams } from 'url';
// 3p
import {
ConfigMock,
Context,
createApp,
createService,
HttpResponseBadRequest,
HttpResponseOK,
isHttpResponseRedirect,
Post
} from '@foal/core';
// FoalTS
import {
AbstractProvider,
AuthorizationError,
InvalidStateError,
SocialTokens,
TokenError
} from './abstract-provider.service';
const STATE_COOKIE_NAME = 'oauth2-state';
describe('InvalidStateError', () => {
it('should have a "message" property.', () => {
const error = new InvalidStateError();
strictEqual(
error.message,
'Suspicious operation: the state of the callback does not match the state of the authorization request.');
});
it('should have a "name" property.', () => {
const error = new InvalidStateError();
strictEqual(error.name, 'InvalidStateError');
});
});
describe('AuthorizationError', () => {
it('should have a "message" property.', () => {
const error = new AuthorizationError('error1', 'error description', 'error URI');
strictEqual(
error.message,
`The authorization server returned an error. Impossible to get an authorization code.
- error: error1
- description: error description
- URI: error URI`
);
});
it('should have a "name" property.', () => {
const error = new AuthorizationError('error1', 'error description', 'error URI');
strictEqual(error.name, 'AuthorizationError');
});
it('should have an "error" property.', () => {
const error = new AuthorizationError('error1', 'error description', 'error URI');
strictEqual(error.error, 'error1');
});
it('should have an "errorDescription" property.', () => {
const error = new AuthorizationError('error1', 'error description', 'error URI');
strictEqual(error.errorDescription, 'error description');
});
it('should have an "errorUri" property.', () => {
const error = new AuthorizationError('error1', 'error description', 'error URI');
strictEqual(error.errorUri, 'error URI');
});
});
describe('TokenError', () => {
it('should have a "message" property.', () => {
const err = {
foo: 'bar'
};
const error = new TokenError(err);
strictEqual(
error.message,
`The authorization server returned an error. Impossible to get an access token.
{
"foo": "bar"
}`
);
});
it('should have a "name" property.', () => {
const error = new TokenError({});
strictEqual(error.name, 'TokenError');
});
it('should have an "error" property.', () => {
const err = {
foo: 'bar'
};
const error = new TokenError(err);
strictEqual(error.error, err);
});
});
describe('AbstractProvider', () => {
class ConcreteProvider extends AbstractProvider<any, any> {
protected configPaths = {
clientId: 'settings.social.example.clientId',
clientSecret: 'settings.social.example.clientSecret',
redirectUri: 'settings.social.example.redirectUri'
};
protected authEndpoint = 'https://example2.com/auth';
protected tokenEndpoint = 'http://localhost:3000/token';
getUserInfoFromTokens(tokens: SocialTokens) {
throw new Error('Method not implemented.');
}
}
let provider: ConcreteProvider;
let configInstance: ConfigMock;
const clientId = 'clientIdXXX';
const clientSecret = 'clientSecretYYY';
const redirectUri = 'https://example.com/callback';
beforeEach(() => {
configInstance = new ConfigMock();
configInstance.set('settings.social.example.clientId', clientId);
configInstance.set('settings.social.example.clientSecret', clientSecret);
configInstance.set('settings.social.example.redirectUri', redirectUri);
provider = createService(ConcreteProvider, { configInstance });
});
describe('has a "redirect" method that', () => {
it('should return an HttpResponseRedirect object.', async () => {
const result = await provider.redirect();
strictEqual(isHttpResponseRedirect(result), true);
});
describe('should return an HttpResponseRedirect object', () => {
it('with a redirect path which contains a client ID, a response type, a redirect URI.', async () => {
const response = await provider.redirect();
ok(response.path.startsWith(
'https://example2.com/auth?'
+ 'response_type=code&'
+ 'client_id=clientIdXXX&'
+ 'redirect_uri=https%3A%2F%2Fexample.com%2Fcallback'
));
});
it('with a redirect path which does not contain a scope if none was provided.', async () => {
const response = await provider.redirect();
const searchParams = new URLSearchParams(response.path);
strictEqual(searchParams.get('scope'), null);
});
it('with a redirect path which contains the scopes if any are provided by the class.', async () => {
class ConcreteProvider2 extends ConcreteProvider {
defaultScopes = [ 'scope1', 'scope2' ];
}
provider = createService(ConcreteProvider2, { configInstance });
const response = await provider.redirect();
const searchParams = new URLSearchParams(response.path);
strictEqual(searchParams.get('scope'), 'scope1 scope2');
});
it('with a redirect path which contains the scopes if any are provided by the class'
+ ' (custom separator).', async () => {
class ConcreteProvider2 extends ConcreteProvider {
defaultScopes = [ 'scope1', 'scope2' ];
scopeSeparator = ',';
}
provider = createService(ConcreteProvider2, { configInstance });
const response = await provider.redirect();
const searchParams = new URLSearchParams(response.path);
strictEqual(searchParams.get('scope'), 'scope1,scope2');
});
it('with a redirect path which contains the scopes if any are provided to the method.', async () => {
class ConcreteProvider2 extends ConcreteProvider {
// This checks that the default scopes will be override.
defaultScopes = [ 'scope1', 'scope2' ];
}
provider = createService(ConcreteProvider2, { configInstance });
const response = await provider.redirect({
scopes: [ 'scope3', 'scope4' ]
});
const searchParams = new URLSearchParams(response.path);
strictEqual(searchParams.get('scope'), 'scope3 scope4');
});
it('with a generated state to protect against CSRF attacks.', async () => {
const response = await provider.redirect();
const stateCookieValue = response.getCookie(STATE_COOKIE_NAME).value;
const stateCookieOptions = response.getCookie(STATE_COOKIE_NAME).options;
if (typeof stateCookieValue !== 'string') {
throw new Error('Cookie not found.');
}
deepStrictEqual(stateCookieOptions, {
httpOnly: true,
maxAge: 300,
path: '/',
secure: false
});
const searchParams = new URLSearchParams(response.path);
const stateParamValue = searchParams.get('state');
if (typeof stateParamValue !== 'string') {
throw new Error('State parameter not found.');
}
strictEqual(stateParamValue, stateCookieValue);
notStrictEqual(stateCookieValue.length, 0);
});
it('with a generated state in a cookie whose secure option is defined with the config.', async () => {
configInstance.set('settings.social.cookie.secure', true);
const response = await provider.redirect();
const { options } = response.getCookie(STATE_COOKIE_NAME);
strictEqual(options.secure, true);
});
it('with a redirect path which contains extra parameters if any are provided to the method.', async () => {
provider = createService(ConcreteProvider, { configInstance });
const response = await provider.redirect({}, { foo: 'bar2' });
const searchParams = new URLSearchParams(response.path);
strictEqual(searchParams.get('foo'), 'bar2');
});
});
});
describe('has a "getTokens" method that', () => {
let server;
afterEach(() => {
if (server) {
server.close();
}
});
it('should throw an InvalidStateError if the query param "state" is not equal '
+ 'to the cookie state value.', async () => {
const ctx = new Context({
cookies: {
[STATE_COOKIE_NAME]: 'xxx'
},
query: {},
});
try {
await provider.getTokens(ctx);
throw new Error('getTokens should have thrown an InvalidStateError.');
} catch (error) {
if (!(error instanceof InvalidStateError)) {
throw error;
}
}
});
it('should throw an AuthorizationError if the request contains a query param "error".', async () => {
const ctx = new Context({
cookies: {
[STATE_COOKIE_NAME]: 'xxx'
},
query: {
error: 'access_denied',
error_description: 'yyy',
error_uri: 'zzz',
state: 'xxx',
},
});
try {
await provider.getTokens(ctx);
throw new Error('getTokens should have thrown an AuthorizationError.');
} catch (error) {
if (!(error instanceof AuthorizationError)) {
throw error;
}
strictEqual(error.error, 'access_denied');
strictEqual(error.errorDescription, 'yyy');
strictEqual(error.errorUri, 'zzz');
}
});
it('should send a request which contains a grant type, a code, a redirect URI,'
+ 'a client ID and a client secret and return the response body.', async () => {
class AppController {
@Post('/token')
token(ctx: Context) {
const { grant_type, code, redirect_uri, client_id, client_secret } = ctx.request.body;
strictEqual(grant_type, 'authorization_code');
strictEqual(code, 'an_authorization_code');
strictEqual(redirect_uri, redirectUri);
strictEqual(client_id, clientId);
strictEqual(client_secret, clientSecret);
return new HttpResponseOK({
access_token: 'an_access_token',
token_type: 'bearer'
});
}
}
server = createApp(AppController).listen(3000);
const ctx = new Context({
cookies: {
[STATE_COOKIE_NAME]: 'xxx'
},
query: {
code: 'an_authorization_code',
state: 'xxx',
},
});
const actual = await provider.getTokens(ctx);
const expected: SocialTokens = {
access_token: 'an_access_token',
token_type: 'bearer'
};
deepStrictEqual(actual, expected);
});
it('should throw a TokenError if the token endpoint returns an error.', async () => {
class AppController {
@Post('/token')
token() {
return new HttpResponseBadRequest({
error: 'bad request'
});
}
}
server = createApp(AppController).listen(3000);
const ctx = new Context({
cookies: {
[STATE_COOKIE_NAME]: 'xxx'
},
query: {
code: 'an_authorization_code',
state: 'xxx',
},
});
try {
await provider.getTokens(ctx);
throw new Error('getTokens should have thrown a TokenError.');
} catch (error) {
if (!(error instanceof TokenError)) {
throw error;
}
deepStrictEqual(error.error, {
error: 'bad request'
});
}
});
});
describe('has a "getUserInfo" method that', () => {
let server;
beforeEach(() => {
provider = createService(ConcreteProvider, { configInstance });
});
afterEach(() => {
if (server) {
server.close();
}
});
it('should return the tokens.', async () => {
class AppController {
@Post('/token')
token() {
return new HttpResponseOK({
access_token: 'an_access_token',
token_type: 'bearer'
});
}
}
server = createApp(AppController).listen(3000);
const ctx = new Context({
cookies: {
[STATE_COOKIE_NAME]: 'xxx'
},
query: {
code: 'an_authorization_code',
state: 'xxx',
},
});
class ConcreteProvider2 extends ConcreteProvider {
getUserInfoFromTokens(tokens: SocialTokens) {
// Do not throw an error.
}
}
provider = createService(ConcreteProvider2, { configInstance });
const { tokens } = await provider.getUserInfo(ctx);
const expectedTokens: SocialTokens = {
access_token: 'an_access_token',
token_type: 'bearer'
};
deepStrictEqual(tokens, expectedTokens);
});
it('should call the "getUserInfoFromTokens" method with the retrieved tokens and the given params.', async () => {
const tokens: SocialTokens = {
access_token: 'an_access_token',
token_type: 'bearer'
};
const params = {
fields: [ 'email' ]
};
class AppController {
@Post('/token')
token() {
return new HttpResponseOK(tokens);
}
}
server = createApp(AppController).listen(3000);
const ctx = new Context({
cookies: {
[STATE_COOKIE_NAME]: 'xxx'
},
query: {
code: 'an_authorization_code',
state: 'xxx',
},
});
let calledWithTokens: null|SocialTokens = null;
let calledWithParams: null|any = null;
class ConcreteProvider2 extends ConcreteProvider {
getUserInfoFromTokens(tokens: SocialTokens, params?: any) {
calledWithTokens = tokens;
calledWithParams = params || null;
}
}
provider = createService(ConcreteProvider2, { configInstance });
await provider.getUserInfo(ctx, params);
deepStrictEqual(calledWithTokens, tokens);
deepStrictEqual(calledWithParams, params);
});
it('should return the user info returned by the "getUserInfoFromTokens" method.', async () => {
class AppController {
@Post('/token')
token() {
return new HttpResponseOK({
access_token: 'an_access_token',
token_type: 'bearer'
});
}
}
server = createApp(AppController).listen(3000);
const ctx = new Context({
cookies: {
[STATE_COOKIE_NAME]: 'xxx'
},
query: {
code: 'an_authorization_code',
state: 'xxx',
},
});
const expectedUserInfo = { email: 'alix@foalts.org' };
class ConcreteProvider2 extends ConcreteProvider {
async getUserInfoFromTokens() {
return expectedUserInfo;
}
}
provider = createService(ConcreteProvider2, { configInstance });
const { userInfo } = await provider.getUserInfo(ctx);
strictEqual(userInfo, expectedUserInfo);
});
});
});