Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foal connect: projects "connected" on Windows do not build on unix systems #562

Closed
LoicPoullain opened this issue Oct 28, 2019 · 5 comments · Fixed by #838
Closed

foal connect: projects "connected" on Windows do not build on unix systems #562

LoicPoullain opened this issue Oct 28, 2019 · 5 comments · Fixed by #838

Comments

@LoicPoullain
Copy link
Member

Issue

When running the tests on the CLI on Windows, I noticed that some of them failed because connect vue and connect angular update the frontend configuration files with back slashes:

"outputPath": "..\\backend\\public"
instead of:
"outputPath": "../backend/public"

For people using Windows and the connect feature, does the command npm run build work on the frontend project?

@LoicPoullain
Copy link
Member Author

LoicPoullain commented May 8, 2020

Update: projects generated on Windows do not build on unix systems because of the backslashes.

@LoicPoullain LoicPoullain moved this from Backlog to Work In Progress in Issue tracking May 8, 2020
@LoicPoullain LoicPoullain changed the title Do foal connect vue and foal connect angular work on Windows? foal connect: projects "connected" on Windows do not build on unix systems May 8, 2020
@LoicPoullain
Copy link
Member Author

Fixed in v1.9

Issue tracking automation moved this from Work In Progress to Done / Closed This Release May 8, 2020
@LoicPoullain LoicPoullain mentioned this issue May 8, 2020
12 tasks
@JuanVqz
Copy link
Contributor

JuanVqz commented Nov 27, 2020

I just saw PR #703 and the change was for angular and vue, shouldn't change the react build to the public folder too?

I said this because today I run the command and it just adds the proxy key pointed up to http://localhost:3001

@LoicPoullain
Copy link
Member Author

At that time, React didn't have a configuration file to specify the path of the build directory (unlike Angular and Vue). Is there any now?

@JuanVqz
Copy link
Contributor

JuanVqz commented Nov 27, 2020

I thought it because the documentation says this and I thought it applies to all of them (Angular/Vue/React), sorry.

The connect command also modifies the build output path of your front so that its bundles are saved in the public/ directory.
This way, you can run the frontend and the backend build commands and directly ship the application to production.

Build Outpath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging a pull request may close this issue.

2 participants