Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove npm warnings when creating a new project. #695

Closed
LoicPoullain opened this issue May 3, 2020 · 3 comments
Closed

Remove npm warnings when creating a new project. #695

LoicPoullain opened this issue May 3, 2020 · 3 comments

Comments

@LoicPoullain
Copy link
Member

Capture d’écran 2020-05-03 à 11 52 00

When creating a new project, we get unnecessary warnings about the description, repository and license.

This could be removed.

@bbeesley
Copy link

bbeesley commented May 3, 2020

Happy to look into this, but there are a couple of options I guess, either modify the package.json templates to populate those fields (repository isn't really possible unless the user inputs it). Not sure this is totally sensible anyway since the user should really enter these at some point.

A better option might be to just mute the warns on that initial install. This is super easy to do with npm, but very difficult with yarn (it's "warn" method writes direct to process.stdout even with the silent option enabled). For that I'd have to write a processor to read from the child process stdout, filter out the warnings, and pass the non warning messages back out to the main process stdout.

Which route would you prefer going down?

@LoicPoullain
Copy link
Member Author

Good catch for the yarn issue!

I'd prefer to go for the first one because it will be easier to maintain in the future. The less code we have to deal with in the framework, the better it is. Child processes might also be harder to unit test.

Would it work if we add the repository field but with an empty string?

@LoicPoullain LoicPoullain moved this from To Do to Work In Progress in Issue tracking Jul 16, 2020
@LoicPoullain
Copy link
Member Author

LoicPoullain commented Jul 16, 2020

Fixed in v1.10.0

Issue tracking automation moved this from Work In Progress to Done / Closed This Release Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

No branches or pull requests

2 participants