Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special handling for resubmitted results #1606

Open
bb30994 opened this issue Dec 11, 2020 · 0 comments
Open

Special handling for resubmitted results #1606

bb30994 opened this issue Dec 11, 2020 · 0 comments
Labels
1.Type - Enhancement Reported issue is an enhamcement. 3.Component - Servers (AS/WS/CS) Reported issue relates to F@H Server Infrastructure. 4.OS - All Reported issue occurs on all supported OS platforms.

Comments

@bb30994
Copy link

bb30994 commented Dec 11, 2020

Your issue may already be reported!
Please search on the issue tracker before creating one.

Your Environment

  • F@H Software version:current
  • Operating System: Windows, but probably others
  • Browser: n/a

Expected Behavior

When the exact same WU that has already been credited is resubmitted (by the same person) it is rejected by the server ... preventing getting double credit for the same WU. FAHClient needs to be told to delete (clean-up) the local copy so it stops being resubmitted perpetually.

Current Behavior

For most clients, the first successful submittal of a WU informs the client to clean up the local copy ... probably with a simple ACK. This works most of the time. In rare instances, the router has firmware that "optimizes" the protocol stream, perhaps by dropping the "unnecessary" ACK. Thus local copies of completed results accumulate -- until FAHClient decides they've expired.

When FAHClient uploads the same WU again, the server needs to inform the client to clean up the (unnecessary) WU. Special care needs to be paid that this change does NOT discard any WUs that still need to be accepted so it's challenging bug-fix.


Possible Solution (Optional)


Steps To Reproduce

  1. Obtain a router that over-optimizes the protocol stream. ;)
  2. Proceed normally

Context


@PantherX PantherX added 1.Type - Enhancement Reported issue is an enhamcement. 3.Component - Servers (AS/WS/CS) Reported issue relates to F@H Server Infrastructure. 4.OS - All Reported issue occurs on all supported OS platforms. labels Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.Type - Enhancement Reported issue is an enhamcement. 3.Component - Servers (AS/WS/CS) Reported issue relates to F@H Server Infrastructure. 4.OS - All Reported issue occurs on all supported OS platforms.
Projects
None yet
Development

No branches or pull requests

2 participants