Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append cpu description after CPUs count #122

Open
kbernhagen opened this issue Jan 24, 2024 · 11 comments
Open

Append cpu description after CPUs count #122

kbernhagen opened this issue Jan 24, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@kbernhagen
Copy link
Contributor

Append cpu description after CPUs count

Since the cpu brand string can be quite long, maybe only add a cpu description for wide layout and no GPUs in group.

@muziqaz asked for this.

@muziqaz
Copy link

muziqaz commented Jan 24, 2024

V7 is already doing it. As I mentioned elsewhere, modern computers have so much screen space horizontally, that I don't think we can use space as an excuse.
However, (not sure how easy it is to implement) CPU model number on its own would be enough, we don't need any of i9 extreme editions. We just need Intel 16400k or AMD 7950x.

@kbernhagen
Copy link
Contributor Author

kbernhagen commented Jan 24, 2024

For reference, one of my computers has
Intel(R) Xeon(R) W-3245 CPU @ 3.20GHz

I'm imagining huge variation in brand strings.
I don't know either how to implement a general shortening function. A lookup table would be huge.

What is v7 showing?

Edit: more examples
Intel(R) Core(TM) i7-4578U CPU @ 3.00GHz
Apple M1

@muziqaz
Copy link

muziqaz commented Jan 24, 2024

V7 is showing the whole string.
So your Xeon can be shown as Intel w-1234

@kbernhagen
Copy link
Contributor Author

Easy enough to strip (R), (TM), CPU @ and whatever follows.

Do you have an AMD example?

@kbernhagen
Copy link
Contributor Author

Alleged on web
Intel(R) Core(TM)2 Duo CPU E8500 @ 3.16GHz

@muziqaz
Copy link

muziqaz commented Jan 24, 2024

Correction: V7 is not showing CPU string in main page of Fahcontrol. Though it has system info tab.
AMD is a bit more human:
AMD Ryzen 9 7950x3d.
So we can strip Ryzen 9 and that would be enough.

This is for support purposes more than aesthetics. If user having issues takes screenshot of web UI, we can see what CPU it is being run on

@kbernhagen
Copy link
Contributor Author

The resources string is created in machine.js get_resources().
I'm thinking it might be best if the client supplied info.cpu_brand_short.

@kbernhagen
Copy link
Contributor Author

AMD Ryzen 9 3900X 12-Core Processor

@muziqaz
Copy link

muziqaz commented Jan 26, 2024

I thought my post was too good to be true 😂
*sigh

@jcoffland
Copy link
Member

GPU descriptions can also be quite long. Looking over gpus.json, a simple filter is not sufficient. One option would be to add a short description field to gpus.json but this would then have to be hand edited. Of course, you could automate most of the initial work by staring with the full descriptions and applying some search and replace operations. I suppose we could just leave things as they are and edit gpus.json to shorten the existing descriptions.

Obviously, there is no such file for CPU descriptions.

I would like to just show as much of the description as screen space allows and then trim the end with ellipsis if it is too long but I have not found a good way to implement this with CSS/HTML. You have to set a fixed width to get text-overflow: ellipsis to work and I don't like the idea of computing the width with Javascript and reformatting on the fly.

@muziqaz
Copy link

muziqaz commented Jan 31, 2024

I thought client/fahcore grabs GPU info from the system (rocminfo, clinfo,nv-equivalent).
And looking at rocm/clinfo outputs card names are pretty short and sweet, like 6900xt. All we need to do is add AMD to it and you have a winner. With Nvidia, RTX 4070 Super or TI is enough, since everyone thinks of Nvidia when they see RTX prefix.
This request is more for us to debug donor issues. We usually ask what is donor's GPU, and sometimes they struggle to tell us. Or sometimes they just post a screenshot of FAH client UI, and if that shows RTX4070S, we are good with that info.
However, if we see gfx1030, that will force 99% of population to Google on what a hell that is, and that will just be family of cards too. And that is not ideal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants