Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Newtonsoft Serializer sending optional values #36

Open
FomTarro opened this issue Dec 3, 2023 · 0 comments
Open

BUG: Newtonsoft Serializer sending optional values #36

FomTarro opened this issue Dec 3, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@FomTarro
Copy link
Owner

FomTarro commented Dec 3, 2023

The old Unity serializer had special logic to prevent it from sending certain optional values. For example, in VTSParameterInjectionValue, the weight field is optional. In the data model, we initialize it as NaN. This stopped it from being included on the serialized model at all in the old way. It seems the new serializer is being overzealous.

Go through the model files and find the various sentinel values we use to try to exclude values from the payload, then update the Newtonsoft serializer to accommodate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant