Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

Highlighting not working on Firefox when CSS has user-select: all #1435

Closed
doubutunomorai opened this issue Feb 22, 2021 · 1 comment · Fixed by #1436
Closed

Highlighting not working on Firefox when CSS has user-select: all #1435

doubutunomorai opened this issue Feb 22, 2021 · 1 comment · Fixed by #1436

Comments

@doubutunomorai
Copy link

Description
go to any page with text that has CSS user-select: all e.g. https://jsfiddle.net/tLm2sx0v/
hover over it (using modifier key if you have one enabled)
nothing happens
works on chrome, only broken on firefox

Browser version
Firefox 85.0.2

Yomichan version
Yomichan 21.1.31.1
@toasted-nutbread toasted-nutbread mentioned this issue Feb 23, 2021
Merged
@toasted-nutbread
Copy link
Collaborator

Nice find, fixed in #1436. Looks like Firefox's caretPositionFromPoint behaves differently than the API Chrome uses (caretRangeFromPoint).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix user select all handling toasted-nutbread/yomichan
2 participants
@toasted-nutbread @doubutunomorai