Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rollup.config.js at projects3.0 #122

Open
atherdon opened this issue Aug 24, 2019 · 6 comments
Open

update rollup.config.js at projects3.0 #122

atherdon opened this issue Aug 24, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@atherdon
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
we discussed this change at your PR. tell me if you can do it in short amount of time, because i'm jumping back into development of this repo and i need rollup at our sub-projects

Is it was created as task at GitHub issues? Please provide an issue number or link

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@atherdon atherdon added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 24, 2019
@atherdon
Copy link
Collaborator Author

as our code was tight with USFA dataset mostly, first item that i have concerns is projects3.0/USFA -i made some changes, but getting an issue with old rollup. i assume that ti will gone with your changes
can be regenerated with yarn build
image

@ebrahim-2
Copy link
Contributor

as I understand from your comment that the problems in the picture come from yarn build and should be fixed

@ebrahim-2
Copy link
Contributor

ebrahim-2 commented Aug 25, 2019

#124

Screenshot from 2019-08-25 09-52-57

@atherdon
Copy link
Collaborator Author

ok, now please check other 2 projects from this folder as well

@ebrahim-2
Copy link
Contributor

ebrahim-2 commented Aug 25, 2019

I think it would be better and make more sense if we make this repo as yarn workspace because there are a lot of shared dependencies and config files between folders...... after I fix rollup in the 2 projects I will make a new food-datasets-csv-parser as yarn workspace in my Github account and you can decide if it makes sense or no

@atherdon
Copy link
Collaborator Author

create a separated issue for that feature. right now it's not in my priority.
when we'll make this repo more clean - then we'll go and complete features like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants