Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csvToJson method enhancement #240

Open
ebrahim-2 opened this issue Oct 28, 2019 · 3 comments
Open

csvToJson method enhancement #240

ebrahim-2 opened this issue Oct 28, 2019 · 3 comments

Comments

@ebrahim-2
Copy link
Contributor

ebrahim-2 commented Oct 28, 2019

should we change csvToJson method implementation to except file name and some config, not dirPath and call parseCsv method inside it I think it will make sense if we use it like this ex:
csvToJson('Restaurants.csv')

and if the user want to add some configuration the call will be like this:
csvToJson('Restaurants.csv, { split: true, maxEntriesPerFile: 5000 }')

@atherdon
Copy link
Collaborator

atherdon commented Oct 28, 2019 via email

@atherdon
Copy link
Collaborator

Btw, if you notice something else that can be a good and simple task - please create it and assign to @sibasish14 because i forget to prepare some future tasks.

Btw, I think soon we'll have a new wave of people that can help us :)

@ebrahim-2
Copy link
Contributor Author

ebrahim-2 commented Oct 29, 2019

okay, I will focus on fixing config files in projects3.0 and I will open issues for coding stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants