Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mathematical functions #32

Closed
ForNeVeR opened this issue Feb 21, 2017 · 4 comments
Closed

Add mathematical functions #32

ForNeVeR opened this issue Feb 21, 2017 · 4 comments
Assignees

Comments

@ForNeVeR
Copy link
Owner

ForNeVeR commented Feb 21, 2017

I have the feature request from Russian F# StackOverflow chat: add arctg and arcctg functions. I think that's time to review the functions we have and add those trigonometric functions we still haven't.

Please note that the ordinary notation for tangent is tan, but tg is also a common extension I think.

Probably these should go into PredefinedTexFormulas.xml.

@ForNeVeR ForNeVeR self-assigned this Feb 21, 2017
@alexreg
Copy link
Collaborator

alexreg commented Feb 22, 2017

Yes, for sure. At some point it may be advantageous to move from an XML definition to some sort of concise code definition... but I'm not 100% sure yet.

@gsomix gsomix changed the title Add trigonometric functions Add mathematical functions Feb 23, 2017
@gsomix
Copy link
Collaborator

gsomix commented Feb 23, 2017

I have updated issue title. We need to add not only trigonometric functions, e.g. \ln, \log, etc.

@ForNeVeR
Copy link
Owner Author

ForNeVeR commented Feb 24, 2017

@alexreg now, when I see the whole picture with that PredefinedTexFormulas.xml file, and how you've embedded that small formula DSL directly into the library, that seems like a very smart idea. Take my compliments.

I'm not sure if we want some other formula definition format. What we have seems pretty much what we need, even if XML is a bit "old school". At the moment, I think we'll just extend that DSL and add new features into it.

@gsomix gsomix mentioned this issue Feb 24, 2017
2 tasks
@alexreg
Copy link
Collaborator

alexreg commented Feb 24, 2017

Okay, fair enough. I generally like to avoid DSLs, but this one does the job fine for now, as you say. A sort of builder-syntax style of defining formulas would be a slight improvement, but maybe not a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants