Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command arguments passed without braces #60

Closed
ForNeVeR opened this issue Feb 26, 2017 · 2 comments
Closed

Command arguments passed without braces #60

ForNeVeR opened this issue Feb 26, 2017 · 2 comments
Labels
kind:bug

Comments

@ForNeVeR
Copy link
Owner

Currently \frac22 fails with an error "missing {" although it actually should render as this:

image

I suggest we take actual EBNF for LaTeX and implement that instead of relying on intuition :)
@ForNeVeR ForNeVeR mentioned this issue Feb 26, 2017
Closed
@B3zaleel
Copy link
Contributor

I changed one of my local versions and it does exactly that, even with the sqrt, underline,frac commands and the script attachments of symbols like (\infty or \oo as in \int_a^\infty). Should I add it to the codebase and create a PR?

B3zaleel added a commit to B3zaleel/xaml-math that referenced this issue Aug 20, 2018
@B3zaleel
ForNeVeR#60 simplified command arguments
70aaacf
@ForNeVeR
Copy link
Owner Author

Yes, thanks!

B3zaleel added a commit to B3zaleel/xaml-math that referenced this issue Aug 28, 2018
@B3zaleel
ForNeVeR#60 frac command params styles
1905bbe 
\frac12 now renders the same as\frac1/2 and \frac1{2}.
Changed some unclear variable names.
B3zaleel added a commit to B3zaleel/xaml-math that referenced this issue Aug 30, 2018
@B3zaleel
ForNeVeR#60 alternate fraction macros extraction method
19d5ac6 
The renewed fraction command allows support for more fraction styles such as \frac17, \frac8/19 and \frac97{2^x \times 5}.
The first and second styles can be terminated by a whitespace and escapeChar at the end, whilst the third style is terminated by a space between the first curly brace and the previous char.
B3zaleel added a commit to B3zaleel/xaml-math that referenced this issue Aug 31, 2018
@B3zaleel
ForNeVeR#60 added a style validator
bebfe08 
Fixed the crash caused when the style is incomplete.
B3zaleel added a commit to B3zaleel/xaml-math that referenced this issue Sep 1, 2018
@B3zaleel
ForNeVeR#60 Updated the fraction command
1390242
@B3zaleel B3zaleel mentioned this issue Sep 15, 2018
Merged
8 tasks
ForNeVeR pushed a commit to B3zaleel/xaml-math that referenced this issue Sep 15, 2018
@B3zaleel @ForNeVeR
ForNeVeR#60 simplified command arguments
2cb4dfd
ForNeVeR pushed a commit to B3zaleel/xaml-math that referenced this issue Sep 15, 2018
@B3zaleel @ForNeVeR
ForNeVeR#60 Updated the fraction command
966e608
ForNeVeR added a commit to B3zaleel/xaml-math that referenced this issue Sep 16, 2018
@ForNeVeR
Add unit tests for the new argument parser (ForNeVeR#60)
7162985
ForNeVeR added a commit to B3zaleel/xaml-math that referenced this issue Sep 16, 2018
@ForNeVeR
ReadElement method, modify \color behavior (ForNeVeR#60)
bdd6cf2
ForNeVeR added a commit to B3zaleel/xaml-math that referenced this issue Sep 17, 2018
@ForNeVeR
Add tests for scripts atom (ForNeVeR#60)
6366350
ForNeVeR added a commit to B3zaleel/xaml-math that referenced this issue Sep 17, 2018
@ForNeVeR
Add styled text parser test (ForNeVeR#60)
c59be1e
ForNeVeR added a commit to B3zaleel/xaml-math that referenced this issue Sep 17, 2018
@ForNeVeR
Add tests for \sqrt's optional argument (ForNeVeR#60)
9009f8e
ForNeVeR added a commit to B3zaleel/xaml-math that referenced this issue Sep 18, 2018
@ForNeVeR
Simplify argument parsing code, use ReadElement everywhere (ForNeVeR#60)
a6e008e
ForNeVeR added a commit to B3zaleel/xaml-math that referenced this issue Sep 18, 2018
@ForNeVeR
Fix \sqrt test, simplify ReadScript (ForNeVeR#60)
9bef561
ForNeVeR added a commit to B3zaleel/xaml-math that referenced this issue Sep 18, 2018
@ForNeVeR
Remove some unnecessary whitespace skips (ForNeVeR#60)
71be375
ForNeVeR added a commit to B3zaleel/xaml-math that referenced this issue Sep 18, 2018
@ForNeVeR
Clean up usings (ForNeVeR#60)
4da8b0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ForNeVeR @B3zaleel