Fixed crash on empty square root #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am sorry for the delay, will review that now. |
ForNeVeR
added a commit
that referenced
this pull request
Jan 10, 2018
|
@sskodje, thank you! I've merged your PR. I've added a unit test for the case that was fixed by your code; please consider adding such tests yourself next time (but always feel free to ask for help!) |
|
@sskodje also please note that I have no plans to publish a new release in the next few weeks. But in case you need the fixed version of WPF-Math to be published to NuGet, just ping me. I could publish a new version out-of-schedule if it's necessary for our users. |
|
No that's quite alright. I have forked and is using that atm, as i'm doing some other changes as well. I'll remember about the unit tests if i make more pull requests:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\sqrt{} resulted in a CTD. This should fix it.