Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move converters to namespace #152

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Move converters to namespace #152

merged 2 commits into from
Aug 23, 2018

Conversation

B3zaleel
Copy link
Contributor

No description provided.

@Happypig375
Copy link

Are you sure this is backwards-compatible?

@B3zaleel
Copy link
Contributor Author

The main code hasn't changed, just the namespace. In case we need to add converters for other mathematical writing formats, it might pollute the main directory.

@ForNeVeR
Copy link
Owner

@B3zaleel yes, it is a breaking change. In case any library user uses the converter in the current namespace, their code will break with library update.

Although, technically, we could still make breaking changes (because we're still in 0.x version range), and I welcome everybody to share their thoughts on the matter. It's better to break things right now, before we've entered the 1.0 version range.

I was going to deny that breaking change, but @B3zaleel made a really good argument about possibility of adding new converters.

@ForNeVeR
Copy link
Owner

Thanks for your contribution!

@ForNeVeR ForNeVeR merged commit a3eff10 into ForNeVeR:master Aug 23, 2018
@B3zaleel B3zaleel deleted the patch-7 branch September 1, 2018 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants