Fixed a crash due to Atom source being null when reading source length. #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it is intended to sometimes have I'm thinking about including and introducing JetBrains external annotations for our code to mark what is nullable and what isn't, but at the same time, C# 8 should be released soonish and we'll be able to do the same annotations with native C# syntax. So, for now, I'll go ahead, add test for this case and merge your PR. Thanks a lot for your contribution! |
ForNeVeR
approved these changes
Jan 7, 2019
ForNeVeR
added a commit
that referenced
this pull request
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain situations, the Source of scriptsAtom is null, like on {\hat T}. This causes the nullreference exception. I'm not clear on wheter it's supposed to be able to null or not, but i believe "position - initialPosition" should always be equal to the source length anyway.