\mathrm{} shouldn't throw exn
#212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"\mathrm{} shouldn't throw exn"
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
command `mathrm{}`
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ForNeVeR
reviewed
Oct 17, 2019
This comment has been minimized.
This comment has been minimized.
RowAtom on check null and replacement for NullAtom
|
Well, maybe it should be so. |
ForNeVeR
reviewed
Oct 19, 2019
src/WpfMath/TexFormula.cs
Outdated
| @@ -33,7 +33,6 @@ public TexRenderer GetRenderer(TexStyle style, double scale, string systemTextFo | |||
| public void Add(TexFormula formula, SourceSpan source = null) | |||
| { | |||
| Debug.Assert(formula != null); | |||
| Debug.Assert(formula.RootAtom != null); | |||
There was a problem hiding this comment.
I don't think you need to remove these assertions now (when the new code produces non-nullable items for these formulas), do you?
|
Aside from my last comment, everything else looks good. |
ForNeVeR
approved these changes
Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change state "\mathrm{} should throw exn" to "\mathrm{} shouldn't throw exn"