Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delimiter type constraint #54

Merged
merged 3 commits into from
Feb 26, 2017
Merged

Remove delimiter type constraint #54

merged 3 commits into from
Feb 26, 2017

Conversation

ForNeVeR
Copy link
Owner

After report by @alexreg in #14 that | doesn't work I decided to review the delimiter typing. I've found that things like \left) are actually supposed to work, so I removed the constraint on the delimiter type from the closing brace code.

That way, now things like \left| \frac{2}{2} \right| work, and even \left) \frac{2}{2} \right|.

image

@ForNeVeR ForNeVeR self-assigned this Feb 26, 2017
Copy link
Collaborator

@gsomix gsomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForNeVeR ForNeVeR merged commit 11e55c7 into master Feb 26, 2017
@ForNeVeR
Copy link
Owner Author

Thanks for the review.

@ForNeVeR ForNeVeR deleted the feature/14-delimiters branch February 26, 2017 12:03
@alexreg
Copy link
Collaborator

alexreg commented Feb 26, 2017

Yep, I think this is the right way to go about things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants