Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TexRenderer: abstract guidelines from drawing code #72

Merged
merged 2 commits into from Mar 13, 2017

Conversation

ForNeVeR
Copy link
Owner

@ForNeVeR ForNeVeR commented Mar 12, 2017

That's a follow-up for #71. I've decided to abstract the guidelines code from the Draw method, and implement the Template method pattern (with DrawWithGuidelines being the template method and Draw being the primitive) for the following purposes:

Now every box uses DrawBackground method and every box supports guidelines (my previous implementation worked only for HorizontalBox and VerticalBox).

@ForNeVeR ForNeVeR self-assigned this Mar 12, 2017
@ForNeVeR ForNeVeR requested review from alexreg and gsomix March 12, 2017 04:26
@ForNeVeR ForNeVeR force-pushed the refactor/guidelines-generalized branch from d77887a to e38aa73 Compare March 12, 2017 04:29
@ForNeVeR ForNeVeR force-pushed the refactor/guidelines-generalized branch from e38aa73 to ebd0cdf Compare March 12, 2017 04:32
Copy link
Collaborator

@alexreg alexreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Let's change the start-up project to the example project though, okay?

@ForNeVeR
Copy link
Owner Author

Yep, sure. Thanks for the review!

@ForNeVeR ForNeVeR merged commit 60c3ec0 into master Mar 13, 2017
@ForNeVeR ForNeVeR deleted the refactor/guidelines-generalized branch March 13, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants