Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "@" to the start of single line .cmd files #12

Merged
merged 2 commits into from
Sep 6, 2015
Merged

Add "@" to the start of single line .cmd files #12

merged 2 commits into from
Sep 6, 2015

Conversation

SkyLined
Copy link

@SkyLined SkyLined commented Mar 5, 2015

To prevent the command from being echoed to the console, add a "@" to the start of the line.

To prevent the command from being echoed to the console, add a "@" to
the start of the line.
ForbesLindesay added a commit that referenced this pull request Sep 6, 2015
Add "@" to the start of single line .cmd files
@ForbesLindesay ForbesLindesay merged commit c661fb7 into npm:master Sep 6, 2015
@ForbesLindesay
Copy link
Contributor

Would you like to be added as a collaborator on this project, to help review and merge pull requests?

@SkyLined
Copy link
Author

SkyLined commented Sep 8, 2015

Sure - though I cannot promise I can commit much time. But I don't believe this project has a lot of code changes, does it?

@ForbesLindesay
Copy link
Contributor

It has very few, but I'm ill placed to review most of them since I use a mac and am not particularly well versed in bash etc.

You're added. Please follow these rules:

  1. never commit directly to master unless you're only editing documentation, or you're in the process of cutting a new release.
  2. never merge your own pull request unless it's had no comments from any collaborators for at least 24 hours.
  3. If you cut a new release, make sure you follow semver when updating the version number.

If you let me know your npm username I'll add you as an owner so you can release new versions :)

@SkyLined
Copy link
Author

Great. My npm username is skylined.

@thefourtheye thefourtheye mentioned this pull request Feb 5, 2016
cspotcode pushed a commit to cspotcode/cmd-shim that referenced this pull request Aug 16, 2019
pr npm#12

* refactor: move some processes to new functions

- Search script runtime
- Generate a shim script

* chore: add JSDoc to `searchScriptRuntime`

* chore: add JSDoc to `writeShim`

* chore: add JSDoc for `writeShimPost`

* chore: add JSDoc for `chmodShim`

* chore: add JSDoc for `writeShimPre`

* chore: add JSDoc for `writeAllShims`

* chore: add JSDoc for `cmdShim_`

* refactor: `writeAllShims`

* fix: ensure `mkdir` called once

* chore: add JSDoc for `extensionToProgramMap`

* chore: add JSDoc for `generate*Shim`

* refactor: diet variables in `generate*Shim`

* chore: add type `ShimGenerator` in JSDoc

* fix: correct wrong type in JSDoc of `writeAllShims`

Co-Authored-By: tats-u <tats.u@live.jp>

* fix: correct wrong type in JSDoc of `generateShim`

Co-Authored-By: tats-u <tats.u@live.jp>

* fix: correct wrong type in JSDoc of `generateCmdShim`

Co-Authored-By: tats-u <tats.u@live.jp>

* fix: correct wrong type in JSDoc of `generatePwshShim`

Co-Authored-By: tats-u <tats.u@live.jp>

* fix: make `ShimGenerator` callback function

* fix: use `@propery` to define `RuntimeInfo`

* fix: isolate JSDoc definition of `RuntimeInfo`

* fix: move description of `ShimGenerator`

Co-Authored-By: tats-u <tats.u@live.jp>

* fix: add type definition of `generatorAndExtPairs`

Co-Authored-By: tats-u <tats.u@live.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants