Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in GitHub Enterprise #11

Open
vasilescur opened this issue Jun 14, 2018 · 3 comments
Open

Doesn't work in GitHub Enterprise #11

vasilescur opened this issue Jun 14, 2018 · 3 comments

Comments

@vasilescur
Copy link

This plugin does not seem to work on an Enterprise GitHub, where the URL is on a sub-domain of my company.

For example, I'm on something like github.XXX.COMPANY.com, and the names are not replaced.

@ForbesLindesay
Copy link
Owner

A pull request would be welcomed. I don't use GitHub Enterprise myself, so I can't test it there.

@geoffroyjabouley
Copy link

Plugin is using hard-coded github.com url to access user API:
https://github.com/ForbesLindesay/github-real-names/blob/master/index.js#L19

Maybe the only thing to do would be to make this url configurable, but i have no skill to do that :(

@ForbesLindesay
Copy link
Owner

It's also only applied to the github.com domain: https://github.com/ForbesLindesay/github-real-names/blob/master/manifest.json#L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants