Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(smart_relations): filtering over smart relationship was broken #145

Merged
merged 1 commit into from Aug 11, 2023
Merged

fix(smart_relations): filtering over smart relationship was broken #145

merged 1 commit into from Aug 11, 2023

Conversation

jbarreau
Copy link
Collaborator

@jbarreau jbarreau commented Aug 10, 2023 •
edited

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

SteveBunlon
SteveBunlon approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@SteveBunlon SteveBunlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jbarreau jbarreau merged commit a294d1b into main Aug 11, 2023
21 checks passed
@jbarreau jbarreau deleted the fix_filter_over_smart_relations branch August 11, 2023 15:30
forest-bot added a commit that referenced this pull request Aug 11, 2023
@forest-bot
chore(release): 1.6.7 [skip ci]
e133181 
## [1.6.7](v1.6.6...v1.6.7) (2023-08-11)

### Bug Fixes

* **smart_relations:** filtering over smart relationship was broken ([#145](#145)) ([a294d1b](a294d1b))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.6.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthv matthv matthv approved these changes

@SteveBunlon SteveBunlon SteveBunlon approved these changes

@jeffladiray jeffladiray Awaiting requested review from jeffladiray

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbarreau @forest-bot @matthv @SteveBunlon