Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow filtering on exact date on flattened field #1079

Merged
merged 7 commits into from Dec 5, 2023
Merged

fix: allow filtering on exact date on flattened field #1079

merged 7 commits into from Dec 5, 2023

Conversation

realSpok
Copy link
Contributor

@realSpok realSpok commented Nov 30, 2023 •
edited

Definition of Done

#860t27mp4
https://app.clickup.com/t/860t27mp4

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)
  • Ensure that Types have been updated according to your changes (if needed)

Security

  • Consider the security impact of the changes made

@ForestAdmin ForestAdmin deleted a comment from forest-bot Nov 30, 2023
@SteveBunlon SteveBunlon self-requested a review December 4, 2023 09:24
SteveBunlon
SteveBunlon previously approved these changes Dec 4, 2023
View reviewed changes
src/utils/schema.js Outdated Show resolved Hide resolved
@realSpok @SteveBunlon
refactor: review suggestion
69f077e 
Co-authored-by: SteveBunlon <SteveBunlon@users.noreply.github.com>
@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 4, 2023

Code Climate has analyzed commit 8c17d62 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (95% is the threshold).

This pull request will bring the total coverage in the repository to 86.8%.

View more on Code Climate.

@realSpok realSpok merged commit 9ad89fe into main Dec 5, 2023
6 checks passed
@realSpok realSpok deleted the fix/allow-filtering-on-exact-date-on-flattened-field branch December 5, 2023 10:09
@realSpok realSpok mentioned this pull request Dec 7, 2023
Merged
5 tasks
forest-bot added a commit that referenced this pull request Dec 7, 2023
@forest-bot
chore(release): 9.3.14 [skip ci]
8ee643f 
## [9.3.14](v9.3.13...v9.3.14) (2023-12-07)

### Bug Fixes

* allow filtering on exact date on flattened field ([#1079](#1079)) ([9ad89fe](9ad89fe))
* release flattened field filtering fix ([#1081](#1081)) ([0610526](0610526))
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.3.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveBunlon SteveBunlon SteveBunlon approved these changes

Assignees

@realSpok realSpok

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@realSpok @forest-bot @SteveBunlon