fix: bug column name when sequelize model mapping attribute has field… #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option access the schema field columnName instead access directly through the fieldName. Closed ForestAdmin#282 Closed ForestAdmin#273
arnaudbesnier
requested changes
Jul 7, 2019
| return `${schema.name}.${fieldName}`; | ||
| const schemaField = schema.fields.find(schemaField => schemaField.field === fieldName); | ||
| const columnName = schemaField ? schemaField.columnName : fieldName; | ||
| return `${schema.name}.${columnName}`; |
There was a problem hiding this comment.
I think you could factorise this logic in a dedicated method.
It would improve the code maintenance and readability.
There was a problem hiding this comment.
Maybe there is already a method for this purpose in the existing code.
| @@ -318,6 +319,24 @@ const HasManyDissociator = require('../src/services/has-many-dissociator'); | |||
| }); | |||
|
|
|||
| describe('A simple Line Chart per day on an empty users table', () => { | |||
| it('should generate a valid SQL query when models mapped to another field', (done) => { | |||
There was a problem hiding this comment.
"when models mapped to another field" should actually be in a describe in my opinion:
describe('A simple Line Chart per day on an empty users table', () => {
describe('with a group_by_date_field field having a conventional name', () => {
it('should generate a valid SQL query', (done) => {
// TEST
});
});
describe('with a group_by_date_field field having an unconventional name', () => {
it('should generate a valid SQL query', (done) => {
// TEST
});
});
});
|
Plus, not sure this PR fixes this issue: |
Co-Authored-By: Arnaud Besnier <arnaudibesnier@gmail.com>
|
This PR inspired me for the fix. I close it in favor of this one: #301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug column name when sequelize model mapping attribute has field option
access the schema field columnName instead access directly through the fieldName.
Closed #282
Closed #273
Pull Request checklist: