fix: 🐛 fix a regression introduced by changes in the build #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrow functions were no longer transformed to normal function after specifying the build target. As exported function are used with the new keyword in some context (even if they should not), this caused a crash when launching an agent. Linked to CU-7rv8fc
|
Task linked: CU-7rv8fc P1 - Lumber project crash on start with |
VincentMolinie
requested changes
Sep 1, 2020
VincentMolinie
approved these changes
Sep 1, 2020
forest-bot
added a commit
that referenced
this pull request
Sep 1, 2020
## [6.3.8](v6.3.7...v6.3.8) (2020-09-01) ### Bug Fixes * 🐛 fix a regression introduced by changes in the build ([#496](#496)) ([89d94fe](89d94fe))
|
🎉 This PR is included in version 6.3.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow functions were no longer transformed to normal function after specifying the build target. As exported function are used with the new keyword in some context (even if they should not), this caused a crash when launching an agent.
Linked to CU-7rv8fc
There is a mismatch between what is exported by
forest-express-sequelizeand what is expected byforest-express:forest-express-sequelizeexports a plain functionforest-expressuses it as a constructorWhich one is right in this case?
Pull Request checklist: