Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-filter): filtering only on hours now returns the expected records #449

Merged
merged 3 commits into from Apr 27, 2021

Conversation

SteveBunlon
Copy link
Member

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • No automatic tests failures
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@SteveBunlon SteveBunlon changed the base branch from master to upgrade/rails-v6.0.3.6 April 27, 2021 09:29
@SteveBunlon SteveBunlon changed the base branch from upgrade/rails-v6.0.3.6 to upgrade/bundler April 27, 2021 09:30
@codeclimate
Copy link

codeclimate bot commented Apr 27, 2021

Code Climate has analyzed commit fa393eb and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 100.0% (45% is the threshold).

This pull request will bring the total coverage in the repository to 37.2%.

View more on Code Climate.

@forest-bot
Copy link
Member

@SteveBunlon SteveBunlon requested review from GuillaumeCisco and removed request for arnaud-moncel April 27, 2021 09:46
Base automatically changed from upgrade/bundler to master April 27, 2021 13:51
Copy link
Contributor

@GuillaumeCisco GuillaumeCisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 💯
Ready to fire 🔥

@SteveBunlon SteveBunlon merged commit aa02186 into master Apr 27, 2021
@SteveBunlon SteveBunlon deleted the fix/hour-filtering branch April 27, 2021 16:07
forest-bot added a commit that referenced this pull request Apr 27, 2021
## [6.3.2](v6.3.1...v6.3.2) (2021-04-27)

### Bug Fixes

* **date-filter:** filtering only on hours now returns the expected records ([#449](#449)) ([aa02186](aa02186))
@forest-bot
Copy link
Member

🎉 This PR is included in version 6.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants