Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): generate the schema properly on server start while using the classic Autoloader using Rails 5 #463

Conversation

aphilippartd
Copy link
Contributor

Fixes issues in generating .forestadmin-schema.json ending up in an empty set of collections for Rails 6 projects using the Classic Autoloader.

The issue has been raised here

@ghusse ghusse requested a review from arnaudbesnier May 18, 2021 14:38
@arnaudbesnier arnaudbesnier changed the title fix(zeitwerk): Change zeitwerk mode enabled check fix(schema): Generate the schema properly on server start while using the classic Autoloader using Rails 5 May 18, 2021
Copy link
Member

@arnaudbesnier arnaudbesnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool, thanks for the contribution.

@arnaudbesnier arnaudbesnier changed the title fix(schema): Generate the schema properly on server start while using the classic Autoloader using Rails 5 fix(schema): generate the schema properly on server start while using the classic Autoloader using Rails 5 May 18, 2021
@arnaudbesnier arnaudbesnier removed their assignment May 18, 2021
@arnaudbesnier arnaudbesnier merged commit 767236c into ForestAdmin:master May 18, 2021
forest-bot added a commit that referenced this pull request May 18, 2021
## [6.3.7](v6.3.6...v6.3.7) (2021-05-18)

### Bug Fixes

* **schema:** generate the schema properly on server start while using the classic Autoloader using Rails 5 ([#463](#463)) ([767236c](767236c))
@forest-bot
Copy link
Member

🎉 This PR is included in version 6.3.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants