Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix time based graph when timezone is different with database #476

Merged
merged 1 commit into from
Jun 1, 2021
Merged

fix: fix time based graph when timezone is different with database #476

merged 1 commit into from
Jun 1, 2021

Conversation

GuillaumeCisco
Copy link
Contributor

@GuillaumeCisco GuillaumeCisco commented Jun 1, 2021 •
edited

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • No automatic tests failures
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

Thenkei
Thenkei reviewed Jun 1, 2021
View reviewed changes
Copy link
Member

@Thenkei Thenkei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ Are you using the right function ?

app/services/forest_liana/line_stat_getter.rb Outdated Show resolved Hide resolved
@GuillaumeCisco GuillaumeCisco force-pushed the fix-time-based-graph-different-timezone branch from 2791693 to 3494d29 Compare June 1, 2021 13:20
@GuillaumeCisco GuillaumeCisco force-pushed the fix-time-based-graph-different-timezone branch from 3494d29 to dfe74ce Compare June 1, 2021 13:56
@codeclimate
Copy link

codeclimate bot commented Jun 1, 2021

Code Climate has analyzed commit dfe74ce and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (45% is the threshold).

This pull request will bring the total coverage in the repository to 38.2% (0.0% change).

View more on Code Climate.

Thenkei
Thenkei approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@Thenkei Thenkei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code review

It's been a long journey to get this little change. 🔢

⚠️ Automatic tests

We definitely need to add more tests on all this part. Maybe during some Friday afternoon.

✅ Manual tests

We have try every cases. It works as expected. I'm wondering if we will need to go back once the group date use will be fixed. Because joins could have lower performances.

@GuillaumeCisco GuillaumeCisco merged commit 5d9fb89 into master Jun 1, 2021
@GuillaumeCisco GuillaumeCisco deleted the fix-time-based-graph-different-timezone branch June 1, 2021 14:04
forest-bot added a commit that referenced this pull request Jun 1, 2021
@forest-bot
chore(release): 6.4.1 [skip ci]
3f9dd77 
## [6.4.1](v6.4.0...v6.4.1) (2021-06-01)

### Bug Fixes

* fix time based graph when timezone is different with database ([#476](#476)) ([5d9fb89](5d9fb89))
@forest-bot
Copy link
Member

🎉 This PR is included in version 6.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Thenkei added a commit that referenced this pull request Jun 17, 2021
@Thenkei @GuillaumeCisco
@forest-bot @SteveBunlon @SeyZ @slimee @olesyakorovina @ghusse
chore: merge master into beta (#494)
846e6fb 
* fix: fix time based graph when timezone is different with database (#476)

* chore(release): 6.4.1 [skip ci]

## [6.4.1](v6.4.0...v6.4.1) (2021-06-01)

### Bug Fixes

* fix time based graph when timezone is different with database ([#476](#476)) ([5d9fb89](5d9fb89))

* feat(schema): move some meta data under stack attribute to prevent blocking scenarios on DWO (#469)

* chore(release): 6.5.0 [skip ci]

# [6.5.0](v6.4.1...v6.5.0) (2021-06-03)

### Features

* **schema:** move some meta data under stack attribute to prevent blocking scenarios on DWO ([#469](#469)) ([76aa754](76aa754))

* Fix broken image links in the README

* fix: allow smart action endpoints to start with slashes

* chore(release): 6.5.1 [skip ci]

## [6.5.1](v6.5.0...v6.5.1) (2021-06-08)

### Bug Fixes

* allow smart action endpoints to start with slashes ([d4f6a61](d4f6a61))
* allow smart action endpoints to start with slashes ([cf6c6a9](cf6c6a9))

* style: fix alt text in README (#484)

* feat: include role in the user data inside the request (#478)

* chore(release): 6.6.0 [skip ci]

# [6.6.0](v6.5.1...v6.6.0) (2021-06-09)

### Features

* include role in the user data inside the request ([#478](#478)) ([0a34716](0a34716))

* fix: support permissions infos with ruby < 2.7 (#486)

* chore(release): 6.6.1 [skip ci]

## [6.6.1](v6.6.0...v6.6.1) (2021-06-10)

### Bug Fixes

* support permissions infos with ruby < 2.7 ([#486](#486)) ([a611271](a611271))

* fix: stats permissions should be retrieved only one time per team (#489)

* fix: stats permissions should be retrieved only one time per team

* chore: fix the version of semantic-release (#492)

* chore(release): 6.6.2 [skip ci]

## [6.6.2](v6.6.1...v6.6.2) (2021-06-16)

### Bug Fixes

* stats permissions should be retrieved only one time per team ([#489](#489)) ([c2e9104](c2e9104))

Co-authored-by: Cisco Guillaume <guillaumecisco@gmail.com>
Co-authored-by: Forest Bot <arnaud+github-bot@forestadmin.com>
Co-authored-by: SteveBunlon <SteveBunlon@users.noreply.github.com>
Co-authored-by: Sandro Munda <sandro@munda.me>
Co-authored-by: Sliman <smedini@gmail.com>
Co-authored-by: slimane <slimanm@forestadmin.com>
Co-authored-by: Olessya KOROVINA <olesyak@forestadmin.com>
Co-authored-by: Guillaume Gautreau <guillaume+github@ghusse.com>
forest-bot added a commit that referenced this pull request Jul 20, 2021
@forest-bot
chore(release): 7.0.0-beta.6 [skip ci]
b49ef34 
# [7.0.0-beta.6](v7.0.0-beta.5...v7.0.0-beta.6) (2021-07-20)

### Bug Fixes

* allow smart action endpoints to start with slashes ([d4f6a61](d4f6a61))
* allow smart action endpoints to start with slashes ([cf6c6a9](cf6c6a9))
* fix time based graph when timezone is different with database ([#476](#476)) ([5d9fb89](5d9fb89))
* stats permissions should be retrieved only one time per team ([#489](#489)) ([c2e9104](c2e9104))
* support permissions infos with ruby < 2.7 ([#486](#486)) ([a611271](a611271))

### Features

* include role in the user data inside the request ([#478](#478)) ([0a34716](0a34716))
* **schema:** move some meta data under stack attribute to prevent blocking scenarios on DWO ([#469](#469)) ([76aa754](76aa754))
@forest-bot
Copy link
Member

🎉 This PR is included in version 7.0.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

HiroshiWatanabe1011 added a commit to HiroshiWatanabe1011/Forest-Rails that referenced this pull request Jun 3, 2024
@HiroshiWatanabe1011
chore(release): 6.4.1 [skip ci]
16c6370 
## [6.4.1](ForestAdmin/forest-rails@v6.4.0...v6.4.1) (2021-06-01)

### Bug Fixes

* fix time based graph when timezone is different with database ([#476](ForestAdmin/forest-rails#476)) ([5d9fb89](ForestAdmin/forest-rails@5d9fb89))
HiroshiWatanabe1011 pushed a commit to HiroshiWatanabe1011/Forest-Rails that referenced this pull request Jun 3, 2024
@Thenkei @GuillaumeCisco
@forest-bot @SteveBunlon @SeyZ @slimee @olesyakorovina @ghusse
chore: merge master into beta (#494)
96c0ffa 
* fix: fix time based graph when timezone is different with database (#476)

* chore(release): 6.4.1 [skip ci]

## [6.4.1](ForestAdmin/forest-rails@v6.4.0...v6.4.1) (2021-06-01)

### Bug Fixes

* fix time based graph when timezone is different with database ([#476](ForestAdmin/forest-rails#476)) ([5d9fb89](ForestAdmin/forest-rails@5d9fb89))

* feat(schema): move some meta data under stack attribute to prevent blocking scenarios on DWO (#469)

* chore(release): 6.5.0 [skip ci]

# [6.5.0](ForestAdmin/forest-rails@v6.4.1...v6.5.0) (2021-06-03)

### Features

* **schema:** move some meta data under stack attribute to prevent blocking scenarios on DWO ([#469](ForestAdmin/forest-rails#469)) ([76aa754](ForestAdmin/forest-rails@76aa754))

* Fix broken image links in the README

* fix: allow smart action endpoints to start with slashes

* chore(release): 6.5.1 [skip ci]

## [6.5.1](ForestAdmin/forest-rails@v6.5.0...v6.5.1) (2021-06-08)

### Bug Fixes

* allow smart action endpoints to start with slashes ([d4f6a61](ForestAdmin/forest-rails@d4f6a61))
* allow smart action endpoints to start with slashes ([cf6c6a9](ForestAdmin/forest-rails@cf6c6a9))

* style: fix alt text in README (#484)

* feat: include role in the user data inside the request (#478)

* chore(release): 6.6.0 [skip ci]

# [6.6.0](ForestAdmin/forest-rails@v6.5.1...v6.6.0) (2021-06-09)

### Features

* include role in the user data inside the request ([#478](ForestAdmin/forest-rails#478)) ([0a34716](ForestAdmin/forest-rails@0a34716))

* fix: support permissions infos with ruby < 2.7 (#486)

* chore(release): 6.6.1 [skip ci]

## [6.6.1](ForestAdmin/forest-rails@v6.6.0...v6.6.1) (2021-06-10)

### Bug Fixes

* support permissions infos with ruby < 2.7 ([#486](ForestAdmin/forest-rails#486)) ([a611271](ForestAdmin/forest-rails@a611271))

* fix: stats permissions should be retrieved only one time per team (#489)

* fix: stats permissions should be retrieved only one time per team

* chore: fix the version of semantic-release (#492)

* chore(release): 6.6.2 [skip ci]

## [6.6.2](ForestAdmin/forest-rails@v6.6.1...v6.6.2) (2021-06-16)

### Bug Fixes

* stats permissions should be retrieved only one time per team ([#489](ForestAdmin/forest-rails#489)) ([c2e9104](ForestAdmin/forest-rails@c2e9104))

Co-authored-by: Cisco Guillaume <guillaumecisco@gmail.com>
Co-authored-by: Forest Bot <arnaud+github-bot@forestadmin.com>
Co-authored-by: SteveBunlon <SteveBunlon@users.noreply.github.com>
Co-authored-by: Sandro Munda <sandro@munda.me>
Co-authored-by: Sliman <smedini@gmail.com>
Co-authored-by: slimane <slimanm@forestadmin.com>
Co-authored-by: Olessya KOROVINA <olesyak@forestadmin.com>
Co-authored-by: Guillaume Gautreau <guillaume+github@ghusse.com>
HiroshiWatanabe1011 added a commit to HiroshiWatanabe1011/Forest-Rails that referenced this pull request Jun 3, 2024
@HiroshiWatanabe1011
chore(release): 7.0.0-beta.6 [skip ci]
43c0ab2 
# [7.0.0-beta.6](ForestAdmin/forest-rails@v7.0.0-beta.5...v7.0.0-beta.6) (2021-07-20)

### Bug Fixes

* allow smart action endpoints to start with slashes ([d4f6a61](ForestAdmin/forest-rails@d4f6a61))
* allow smart action endpoints to start with slashes ([cf6c6a9](ForestAdmin/forest-rails@cf6c6a9))
* fix time based graph when timezone is different with database ([#476](ForestAdmin/forest-rails#476)) ([5d9fb89](ForestAdmin/forest-rails@5d9fb89))
* stats permissions should be retrieved only one time per team ([#489](ForestAdmin/forest-rails#489)) ([c2e9104](ForestAdmin/forest-rails@c2e9104))
* support permissions infos with ruby < 2.7 ([#486](ForestAdmin/forest-rails#486)) ([a611271](ForestAdmin/forest-rails@a611271))

### Features

* include role in the user data inside the request ([#478](ForestAdmin/forest-rails#478)) ([0a34716](ForestAdmin/forest-rails@0a34716))
* **schema:** move some meta data under stack attribute to prevent blocking scenarios on DWO ([#469](ForestAdmin/forest-rails#469)) ([76aa754](ForestAdmin/forest-rails@76aa754))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thenkei Thenkei Thenkei approved these changes

Assignees

@Thenkei Thenkei

Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GuillaumeCisco @forest-bot @Thenkei