feat(security): secure segments queries #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thenkei
commented
Jun 18, 2021
Comment on lines
+71
to
+75
| refresh_rendering_cache if rendering_cache_expired? | ||
|
|
||
| # NOTICE: In this case we need to check that that query is allowed | ||
| if @collection_list_parameters[:segmentQuery].present? | ||
| return false unless segment_query_allowed? |
Thenkei
commented
Jun 18, 2021
Comment on lines
+161
to
168
| def segment_query_allowed? | ||
| segments_queries_permissions = get_segments_in_permissions | ||
|
|
||
| return false unless segments_queries_permissions | ||
|
|
||
| # NOTICE: @query_request_info matching an existing segment query | ||
| return segments_queries_permissions.include? @collection_list_parameters[:segmentQuery] | ||
| end |
There was a problem hiding this comment.
Relevant code for checking query segments allowed
DrRaider
approved these changes
Jul 1, 2021
forest-bot
added a commit
that referenced
this pull request
Jul 2, 2021
# [7.0.0-beta.3](v7.0.0-beta.2...v7.0.0-beta.3) (2021-07-02) ### Features * **security:** secure segments queries ([#495](#495)) ([571f889](571f889))
|
🎉 This PR is included in version 7.0.0-beta.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Jul 20, 2021
# [7.0.0](v6.6.2...v7.0.0) (2021-07-20) ### Bug Fixes * **dependency:** now using forestadmin-jsonapi-serializers instead of the jsonapi-serializers gem ([#475](#475)) ([3feea36](3feea36)) ### chore * **force-release:** now using forestadmin-jsonapi-serializers instead of the jsonapi-serializers gem ([#464](#464)) ([00ee2a4](00ee2a4)) ### Features * **scopes:** enforce scopes restrictions on a wider range of requests ([#488](#488)) ([66825a3](66825a3)) * smart action hooks now have access to the http request ([#499](#499)) ([5cd4a0e](5cd4a0e)) * **hooks:** developers can dynamically add or remove smart actions fields ([#465](#465)) ([970f3d8](970f3d8)) * **security:** secure segments queries ([#495](#495)) ([571f889](571f889)) ### BREAKING CHANGES * record is no longer send to the hook midleware & values option on smart action is no longer supported * **hooks:** fields parameters on hook function is no longer a map of field, it is now an array. change hook is no longer choosen by the field name, field need to have hook defined inside it definition by addin a props hook. * **dependency:** Switch from jsonapi-serializers to forestadmin-jsonapi-serializers to serialize data to the JSONAPI format, mainly to avoid conflict with the jsonapi-serializer library * **force-release:** Switch from jsonapi-serializers to forestadmin-jsonapi-serializers to serialize data to the JSONAPI format, mainly to avoid conflict with the jsonapi-serializer library
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist: