Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authentication): return errors detail instead of generic error 500 #636

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

matthv
Copy link
Member

@matthv matthv commented Nov 7, 2023

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@matthv matthv changed the title fix(authentication): return errors detail instead of generic error 500 #140 Merged jbarreau merged 5 commits into main from authentication_error_for_pricing 1 hour ago +482 −24 Conversation 1 Commits 5 Checks 32 Files changed 9 fix(authentication): return errors detail instead of generic error 500 Nov 7, 2023
@matthv
Copy link
Member Author

matthv commented Nov 7, 2023

Task linked: CU-860ry48ja forest rails (v1)

Copy link

codeclimate bot commented Nov 16, 2023

Code Climate has analyzed commit 1f82618 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (55% is the threshold).

This pull request will bring the total coverage in the repository to 48.7%.

View more on Code Climate.

@matthv matthv merged commit 1a69e2f into main Nov 16, 2023
6 checks passed
@matthv matthv deleted the fix/auth-error-trial branch November 16, 2023 10:13
forest-bot added a commit that referenced this pull request Nov 16, 2023
## [8.0.16](v8.0.15...v8.0.16) (2023-11-16)

### Bug Fixes

* **authentication:** return errors detail instead of generic error 500 ([#636](#636)) ([1a69e2f](1a69e2f))
@forest-bot
Copy link
Member

🎉 This PR is included in version 8.0.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants