fix: security vulnerabilities RCE on 8.x.x #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| }) | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def count(value) | ||
| uniq = @params[:aggregator].downcase == 'count' | ||
| def aggregate(value) |
There was a problem hiding this comment.
Method aggregate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
nicolasalexandre9
force-pushed
the
fix/rce-stats-main
branch
from
84dc3ff
to
fc79c71
Compare
|
Task linked: CU-860t2tddx Rails v1 - Security vulnerabilities |
| }) | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def count(value) | ||
| uniq = @params[:aggregator].downcase == 'count' | ||
| def aggregate(value) |
There was a problem hiding this comment.
Method aggregate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
matthv
previously approved these changes
Dec 4, 2023
|
Code Climate has analyzed commit 061a8dc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 90.0% (55% is the threshold). This pull request will bring the total coverage in the repository to 48.8%. View more on Code Climate. |
matthv
approved these changes
Dec 5, 2023
forest-bot
added a commit
that referenced
this pull request
Dec 5, 2023
## [8.0.17](v8.0.16...v8.0.17) (2023-12-05) ### Bug Fixes * security vulnerabilities RCE on 8.x.x ([#638](#638)) ([02679b5](02679b5))
|
🎉 This PR is included in version 8.0.17 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
HiroshiWatanabe1011
added a commit
to HiroshiWatanabe1011/Forest-Rails
that referenced
this pull request
Jun 3, 2024
## [8.0.17](ForestAdmin/forest-rails@v8.0.16...v8.0.17) (2023-12-05) ### Bug Fixes * security vulnerabilities RCE on 8.x.x ([#638](ForestAdmin/forest-rails#638)) ([02679b5](ForestAdmin/forest-rails@02679b5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of Done
General
Security