Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove downcase on model name when updated polymorphic association #670

Merged
merged 1 commit into from
May 16, 2024

Conversation

nicolasalexandre9
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@nicolasalexandre9 nicolasalexandre9 changed the title fix: remove downcase on model name fix: remove downcase on model name when updated polymorphic association May 16, 2024
Copy link

codeclimate bot commented May 16, 2024

Code Climate has analyzed commit ffa3d7c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (55% is the threshold).

This pull request will bring the total coverage in the repository to 50.4%.

View more on Code Climate.

@nicolasalexandre9 nicolasalexandre9 merged commit ad5fe26 into main May 16, 2024
5 of 6 checks passed
@nicolasalexandre9 nicolasalexandre9 deleted the fix/update-on-poly-association branch May 16, 2024 12:33
forest-bot added a commit that referenced this pull request May 16, 2024
## [9.3.4](v9.3.3...v9.3.4) (2024-05-16)

### Bug Fixes

* remove downcase on model name when updated polymorphic association ([#670](#670)) ([ad5fe26](ad5fe26))
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Watanabe1011 added a commit to Watanabe1011/Forest-Rails that referenced this pull request Jun 3, 2024
## [9.3.4](ForestAdmin/forest-rails@v9.3.3...v9.3.4) (2024-05-16)

### Bug Fixes

* remove downcase on model name when updated polymorphic association ([#670](ForestAdmin/forest-rails#670)) ([ad5fe26](ForestAdmin/forest-rails@ad5fe26))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants