Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use <i but <span #373

Open
InfoLibre opened this issue Nov 7, 2021 · 4 comments
Open

Don't use <i but <span #373

InfoLibre opened this issue Nov 7, 2021 · 4 comments

Comments

@InfoLibre
Copy link

In all your examples, you say users to write <i class="fa... instead of <span class="fa... You recommand to use span instead of i only at once time on https://forkaweso.me/Fork-Awesome/examples/
The result is that mainly all the projects using Forkawesome are keeping your syntax <i class="fa... and in these cases, the icons are displayed differently, a bit smaller and lower than with a span tag.

Could you change <i by <span in all your examples ?

@InfoLibre
Copy link
Author

@DougInAMug
Copy link
Member

DougInAMug commented Dec 2, 2021

Hey @InfoLibre , thanks for your suggestion.

I'm not sure why <i> was originally used. I'm happy to look into this and update if worthwhile. Do you have any more technical details about the difference between <i> and <span>?

(p.s. I get 1.090.000.000 hits for i and 43.800.000 for span - interesting difference. Also, I'm not sure what you wanted to show with these differences in search results.)

@InfoLibre
Copy link
Author

InfoLibre commented Dec 2, 2021

With <span>:

Capture d’écran du 2021-12-02 21-36-16

With <i>:

Capture d’écran du 2021-12-02 21-40-33

It's weird, I hope I don't have CSS somewhere that might be causing this difference. Anyway, using <i> is not a good choice, <span> would make more sense. I think <i> was used because it's easier to write than <span>.

@LuanHimmlisch
Copy link

I always try to use for the sake of good HTML structure. I imagine that the syntax was adopted for its shortness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants