Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: documentation, clean up, and testing #69

Closed
chrisbolin opened this issue Apr 30, 2020 · 0 comments 路 Fixed by #77
Closed

Types: documentation, clean up, and testing #69

chrisbolin opened this issue Apr 30, 2020 · 0 comments 路 Fixed by #77
Assignees

Comments

@chrisbolin
Copy link
Contributor

chrisbolin commented Apr 30, 2020

BLOCKERS: Fix #61 and #62 in a beta release first.

  • in the README document react-fast-compare's approach to typing: we need to support a huge variety of usages, and therefore the typing must be simple and should probably not be changed 馃槇. Reference all of the issues and PRs we've already had.
  • while the Fix exported types so that they work for react-redux聽#61 fix is still in beta, direct users interested in types to that beta.
  • make a github issue template. Explicitly mention types and direct the filer to the README documentation
  • create TypeScript compilation tests that cover the issues/PRs we've seen so far
  • ensure any other open issues are PRs are updated (probably closed) accordingly

Any of these can be made into separate issues to make tracking easier.

@chrisbolin chrisbolin changed the title Types: documentation and clean up Types: documentation, clean up, and testing Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants