Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lint errors please #194

Closed
tomByrer opened this issue Mar 20, 2020 · 0 comments · Fixed by #263
Closed

fix lint errors please #194

tomByrer opened this issue Mar 20, 2020 · 0 comments · Fixed by #263

Comments

@tomByrer
Copy link

tomByrer commented Mar 20, 2020

Fresh, git clone & build, last commit: c4eee2c Dec 2019

Thanks for your repo! :)

yarn run lint
yarn run v1.22.1
$ eslint --config .eslintrc "./**/*.js"
Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration .

D:\doc\prog\pm\react-live\demo\components\Header.js
  4:30  error  Unable to resolve path to module 'formidable-oss-badges'  import/no-unresolved

D:\doc\prog\pm\react-live\demo\components\LiveEdit.js
   6:66  error    Unable to resolve path to module 'react-live'  import/no-unresolved
  76:21  warning  'noInline' is missing in props validation      react/prop-types
  76:31  warning  'code' is missing in props validation          react/prop-types

D:\doc\prog\pm\react-live\src\components\Editor\index.js
  64:13  error  '_code' is assigned a value but never used     no-unused-vars
  65:7   error  'onChange' is assigned a value but never used  no-unused-vars
  66:7   error  'language' is assigned a value but never used  no-unused-vars

D:\doc\prog\pm\react-live\src\components\Live\LivePreview.js
  4:24  warning  'Component' is missing in props validation  react/prop-types

D:\doc\prog\pm\react-live\stories\Live.js
  137:26  warning  'live' is missing in props validation          react/prop-types
  138:23  warning  'live.element' is missing in props validation  react/prop-types
  143:18  warning  'live.error' is missing in props validation    react/prop-types

✖ 11 problems (5 errors, 6 warnings)
@tomByrer tomByrer changed the title fix lint errors fix lint errors please Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant