Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inline compilation errors #41

Open
bvaughn opened this issue Oct 6, 2017 · 0 comments
Open

Support inline compilation errors #41

bvaughn opened this issue Oct 6, 2017 · 0 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

The LiveError component is useful for displaying compilation errors. But the LiveEditor component could be even more useful if it showed inline errors. For example:

Current UI

screen shot 2017-10-05 at 6 03 58 pm

Potential UI

screen shot 2017-10-05 at 6 03 46 pm

This support could probably be added in such a way that is not dependent on a specific compiler/toolchain. For example, LiveEditor could expose an additional prop errors that looked something like this:

type errors = Array<{
  message: string,
  rowNumber: number,
  columnNumber?: number
}>

This issue is just being opened for discussion and is a follow-up from facebook/react/issues/11094 and reactjs/react.dev/issues/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants