Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Bring spectacle-mdx-loader in to the monorepo #1164

Open
3 of 4 tasks
ryan-roemer opened this issue Jul 28, 2022 · 4 comments · Fixed by #1228
Open
3 of 4 tasks

Infra: Bring spectacle-mdx-loader in to the monorepo #1164

ryan-roemer opened this issue Jul 28, 2022 · 4 comments · Fixed by #1228
Labels
Chore Tasks considered to be routine

Comments

@ryan-roemer
Copy link
Member

ryan-roemer commented Jul 28, 2022

  • Add packages/spectacle-mdx-loader
  • Add examples/mdx that uses the loader
  • Remove old repository
  • Verify we can correctly publish.
@ryan-roemer ryan-roemer added the Chore Tasks considered to be routine label Jul 28, 2022
@paulmarsicloud paulmarsicloud self-assigned this Aug 24, 2022
@paulmarsicloud
Copy link
Contributor

Got a branch in progress for this: https://github.com/FormidableLabs/spectacle/tree/chore/spectacle-mdx-loader-addition 👍

@paulmarsicloud
Copy link
Contributor

Revisited this branch today and I'm a little stuck. On a fresh pnpm install and pnpm start:mdx, http://localhost:3300/ blank screens with a external var "React":1 Uncaught ReferenceError: React is not defined

When I exit and re-run pnpm start:mdx, I get many Module not found: Error: Can't resolve 'react/jsx-runtime' errors even though the module is safely there.

Will continue to chip away at this

@Burnett2k
Copy link
Member

Hi @ryan-roemer , I'm looking back at this and it appears that the old repo is still out there and might cause confusion. Should we archive / delete it to finish out this project? I see in the initial checklist removing the old repo was part of the issue. We probably need to also verify npm publishing works as well.

cc @carbonrobot

@ryan-roemer
Copy link
Member Author

I think this is complete -- current version packages PR includes spectacle-mdx-loader. Plan sounds good -- verify npm publish, archive old repo. Thanks!

@paulmarsicloud paulmarsicloud removed their assignment Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tasks considered to be routine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants