Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

Document titles are all identical (Victory | Documentation) #261

Closed
jamieparkinson opened this issue Mar 10, 2017 · 1 comment
Closed

Document titles are all identical (Victory | Documentation) #261

jamieparkinson opened this issue Mar 10, 2017 · 1 comment

Comments

@jamieparkinson
Copy link
Contributor

jamieparkinson commented Mar 10, 2017 •
edited

It looks like the document titles introduced in #49 have regressed and so every page has the title Victory | Documentation. Presumably this happened when markdown.jsx was removed.

This makes navigating the docs tricky, as all my tabs have the same titles! I've submitted a PR to fix this - of course, let me know if you're not happy with my approach or anything like this.
@jamieparkinson jamieparkinson mentioned this issue Mar 10, 2017
Merged
@jamieparkinson
Copy link
Contributor Author

Oh, and by the way, I'd really like to help with the Victory docs - I like the library a lot and I think the docs would benefit from some additional love, so please ping me if there's anything I can help out with!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamieparkinson