Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Minor version pin for core victory libraries #676

Merged
merged 3 commits into from Aug 26, 2021
Merged

Conversation

gksander
Copy link
Contributor

Issue #674 reports that Victory core 35.11.0 breaks Victory Native. I suspect this is due to some of the class-to-function component conversions in the core (released in 35.11.0) which are not respected in Victory Native.

One solution, short term, is for users to pin their versions via yarn's resolutions field. However, to avoid everyone having to do that, I'm proposing we do minor-version pinning at the library level here so this won't break for future users, and we don't have to tell people to do user-land resolutions to get the library to work.

Eventually, Victory Native's code will need to be updated to potentially move from class inheritance to function composition - but this seems like a fair short-time fix.

@gksander
Copy link
Contributor Author

Now that the breaking changes to Victory core have been rolled back, this PR is not quite necessary. But, minor version pinning does add some safety to avoid this scenario in the future - which would allow Victory core libraries to evolve without breaking Victory Native, and Native could be caught up at a later dated (at which point it'd bump these minor versions).

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gksander !

Copy link

@becca-bailey becca-bailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for now! We should have Victory rolled back by next week, then we can work on figuring out how de-couple from class components. Thanks for this fix!

@gksander gksander merged commit baed61d into main Aug 26, 2021
@gksander gksander deleted the core-version-pinning branch August 26, 2021 16:58
@jlpujante
Copy link

Many thanks @gksander

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants